Skip to content

fix(windows): include objbase.h for webview COM protos #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiensonqin merged 2 commits into from
Oct 12, 2026
Merged

fix(windows): include objbase.h for webview COM protos #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62c5a80
fix(windows): include objbase.h for COM protos when windows.h is lean
tiensonqin Oct 12, 2026
d758120
test(webapp): spawn the launcher directly instead of via sh -c
tiensonqin Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions platform/native/lui_webapp/test/lui_webapp_test.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,13 +376,11 @@ let test_boot_fallback () =

let cli_exe () = Filename.dirname Sys.executable_name / ".." / "main.exe"

(* Spawn the launcher directly: no [sh -c] indirection, whose quoting
and path translation of a native Windows path is shell-dependent
(a fresh Cygwin sh exits 127 on it). *)
let run_cli args =
let cmd =
List.fold_left
(fun acc a -> acc ^ " " ^ Filename.quote a)
(Filename.quote (cli_exe ())) args
in
let r = P.Proc.run "sh" [ "-c"; cmd ] in
let r = P.Proc.run (cli_exe ()) args in
(r.P.Proc.status, String.trim (r.P.Proc.stdout ^ r.P.Proc.stderr))

let test_cli_errors () =
Expand Down
6 changes: 6 additions & 0 deletions platform/native/lui_webview/lui_webview_stubs.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1025,6 +1025,12 @@ extern __declspec(dllimport) long LUI_STDCALL GetHGlobalFromStream(
extern __declspec(dllimport) long LUI_STDCALL CreateStreamOnHGlobal(
void *, int, void **);
extern __declspec(dllimport) void LUI_STDCALL CoTaskMemFree(void *);
#else
/* <windows.h> came in via SDL_syswm.h, which defines
WIN32_LEAN_AND_MEAN: that skips the COM headers, so the real
CoTaskMemFree / CreateStreamOnHGlobal / GetHGlobalFromStream protos
must be pulled in explicitly. */
#include <objbase.h>
#endif /* !WINAPI — no real Win32 headers in this TU */

typedef struct {
Expand Down
Loading