Repository navigation
Add today/yesterday to Timeline dates and clear Detail title - #75
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f8f02684d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| in | ||
| Journal_header.date_header ~title | ||
| Journal_header.date_header | ||
| ?relative_label:(Journal_calendar.relative_day_label ~today day) |
There was a problem hiding this comment.
After local midnight or a time-zone change, install_calendar updates state.calendar immediately, but Journal_timeline_state.today is not advanced until the replacement feed reaches the successful Feed_loaded branch in application.ml. While that request is pending—and indefinitely if it fails—this call therefore continues marking the previous date as today and its predecessor as yesterday. Pass the current sampled calendar day into the presentation independently of feed completion so these labels cannot become stale.
Useful? React with 👍 / 👎.
1 participant
Timeline dates now append lowercase
todayoryesterdayin 15pt default native subheadline regular text in semantic system secondary color with native baseline alignment and a little more separation for the device-local calendar day and its predecessor. Other dates retain their existing text. Labels read the already sampled OCaml calendar immediately, including while a feed refresh is delayed or fails. Gregorian civil-day comparison handles month/year/leap boundaries without subtracting elapsed hours, adding polling, or changing feed reads.Block Detail now supplies an empty navigation title; the native Back button, options menu and toolbar layout remain.
Validation: 86 application-view tests, existing calendar and Timeline state tests, source-boundary checks, and iOS Simulator build passed. An isolated iPhone 13 / iOS 26.1 synthetic host verified date-state changes, year boundary, maximum Dynamic Type, the empty Detail title, native Back and menu selection, with screenshots kept outside Git. No Dune, spec interfaces, lock files or mldoc code changed.