Repository navigation
Render Timeline and Detail block titles with mldoc - #76
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timeline root/child previews and Block Detail now render titles from one native mldoc AST adapter, preserving nested emphasis, code, URL labels and clickable URLs. Only UUID
[[uuid]]page references expand through the existing graph-session cache; ordinary page names, escaped/code tokens and missing/cyclic references retain their text. Nested labels open the outer referenced block while explicit URLs retain their external target.Parsing, conversion, source caching and reference expansion are bounded. Swift maps semantic runs to native AttributedString/Text, retaining Timeline's four-line parent / three two-line children limits and Detail's full text, status, properties, pagination and asset lifecycle. The dependency change pins merged mldoc core
b3e06c030b7396f7992ebe1c3a4f35f5e6983200and XMLm forkeb469d536e98c98f2754c0ff8813c92b3a17fe9fwithin the approved dependency scope. The sealed-interface test locates public CMIs in its actual build directory, retaining all positive/negative compiler assertions.Validation at head
d39d25456c26c632ccbe23e5e8aeecd150e28ed0, after integrating mainbfe5a1298fd4ece44653c6970e473129beed8e6a(PR #75):@runtest,@allandapp/native_embed.exe.o: passed, 788 cases / 21 Alcotest suites, plus standalone package checks.spec-dev-tool check --allstill reports three existing historical document-structure errors outside this change.The Simulator uses the established ARM64 complete-object restamp route and simulator crypto; physical-device/full cross-runtime ABI and a fresh network opam solver/compiler install were not validated locally. Safari foreground opening is asserted; website content/loading is not. All tests used a disposable synthetic graph and memory-only credentials. No phone installation or real graph writes occurred.