Skip to content

Render Timeline and Detail block titles with mldoc - #76

Merged
RCmerci merged 4 commits into
mainfrom
codex/mldoc-block-titles-20261014
Oct 15, 2026
Merged

RCmerci merged 4 commits into
mainfrom
codex/mldoc-block-titles-20261014

Conversation

@RCmerci

@RCmerci RCmerci commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Timeline root/child previews and Block Detail now render titles from one native mldoc AST adapter, preserving nested emphasis, code, URL labels and clickable URLs. Only UUID [[uuid]] page references expand through the existing graph-session cache; ordinary page names, escaped/code tokens and missing/cyclic references retain their text. Nested labels open the outer referenced block while explicit URLs retain their external target.

Parsing, conversion, source caching and reference expansion are bounded. Swift maps semantic runs to native AttributedString/Text, retaining Timeline's four-line parent / three two-line children limits and Detail's full text, status, properties, pagination and asset lifecycle. The dependency change pins merged mldoc core b3e06c030b7396f7992ebe1c3a4f35f5e6983200 and XMLm fork eb469d536e98c98f2754c0ff8813c92b3a17fe9f within the approved dependency scope. The sealed-interface test locates public CMIs in its actual build directory, retaining all positive/negative compiler assertions.

Validation at head d39d25456c26c632ccbe23e5e8aeecd150e28ed0, after integrating main bfe5a1298fd4ece44653c6970e473129beed8e6a (PR #75):

  • Forced full @runtest, @all and app/native_embed.exe.o: passed, 788 cases / 21 Alcotest suites, plus standalone package checks.
  • Actual iPhone 13 / iOS 26.1 Simulator: all 3 committed XCTest cases passed, 0 failures. Covers native layout/truncation, bilingual/CJK full Detail, URL opening, nested-reference navigation and missing/cyclic fallback. Fresh screenshots also show the integrated relative-date headers and empty Detail navigation title.
  • Verified 71 OCaml and 31 Swift production source hashes against the actual build inputs; native linkage used the fixed private mldoc/XMLm archives.
  • App icon packaging, both opam lints and the feature decision document validation passed. spec-dev-tool check --all still reports three existing historical document-structure errors outside this change.

The Simulator uses the established ARM64 complete-object restamp route and simulator crypto; physical-device/full cross-runtime ABI and a fresh network opam solver/compiler install were not validated locally. Safari foreground opening is asserted; website content/loading is not. All tests used a disposable synthetic graph and memory-only credentials. No phone installation or real graph writes occurred.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T00:36:01.473071Z d39d254 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@RCmerci
RCmerci merged commit 7d5a079 into main Oct 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant