-
Notifications
You must be signed in to change notification settings - Fork 140
livekit-api v1.2.2 #824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
github-actions
wants to merge
1
commit into
main
Choose a base branch
from
release/api-v1.2.2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1
−1
Open
livekit-api v1.2.2 #824
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| __version__ = "1.2.1" | ||
| __version__ = "1.2.2" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Duplicate API release publication
Merging
__version__1.2.2 starts the PR publisher, which pushes an API tag. That tag starts the tag publisher, so one identical PyPI upload fails.Learn more
The release workflow runs when a release pull request closes. Its tag job creates
api-v1.2.2, while its API jobs independently build and publish the same version. The tag matches the trigger in Build API, whose publish job uploads another copy. PyPI does not permit replacing an existing filename, so whichever workflow uploads second fails. If the PR-triggered publisher loses, its dependent documentation job does not run.Example: Merge the
release/api-v1.2.2pull request.publish.ymlbegins uploadinglivekit_api-1.2.2and pushesapi-v1.2.2;build-api.ymlthen uploads the same filenames. One workflow reports an existing-file error instead of completing the release path.Recommended fix: Keep one publishing owner for API tags. Either stop
publish.ymlfrom directly publishing after creating the tag, or remove the tag-triggered publish behavior frombuild-api.yml. Ensure documentation depends on the surviving publisher.Was this helpful? React with 👍 or 👎 to provide feedback.