Skip to content

livekit-api v1.2.2 - #824

Open
github-actions[bot] wants to merge 1 commit into
mainfrom
release/api-v1.2.2
Open

github-actions[bot] wants to merge 1 commit into
mainfrom
release/api-v1.2.2

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Merging this PR will publish livekit-api v1.2.2 to PyPI.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

@@ -1 +1 @@
__version__ = "1.2.1"
__version__ = "1.2.2"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Duplicate API release publication

Merging __version__ 1.2.2 starts the PR publisher, which pushes an API tag. That tag starts the tag publisher, so one identical PyPI upload fails.

Learn more

The release workflow runs when a release pull request closes. Its tag job creates api-v1.2.2, while its API jobs independently build and publish the same version. The tag matches the trigger in Build API, whose publish job uploads another copy. PyPI does not permit replacing an existing filename, so whichever workflow uploads second fails. If the PR-triggered publisher loses, its dependent documentation job does not run.

Example: Merge the release/api-v1.2.2 pull request. publish.yml begins uploading livekit_api-1.2.2 and pushes api-v1.2.2; build-api.yml then uploads the same filenames. One workflow reports an existing-file error instead of completing the release path.

Recommended fix: Keep one publishing owner for API tags. Either stop publish.yml from directly publishing after creating the tag, or remove the tag-triggered publish behavior from build-api.yml. Ensure documentation depends on the surviving publisher.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant