Skip to content

chore(baseten): remove dead BasetenSttOptions fields and their defaults #2391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
detail-app wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(baseten): remove dead BasetenSttOptions fields and their defaults #2391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions plugins/baseten/etc/agents-plugin-baseten.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,25 +71,15 @@ export interface BasetenSttOptions {
// (undocumented)
audioLanguage?: string;
// (undocumented)
bufferSizeSeconds?: number;
// (undocumented)
enablePartialTranscripts?: boolean;
// (undocumented)
encoding?: string;
// (undocumented)
environment?: string;
// (undocumented)
finalTranscriptMaxDurationS?: number;
// (undocumented)
languageDetectionOnly?: boolean;
modelEndpoint?: string;
// @deprecated (undocumented)
modelId?: string;
// (undocumented)
partialTranscriptIntervalS?: number;
// (undocumented)
prompt?: string;
// (undocumented)
sampleRate?: number;
// (undocumented)
vadMinSilenceDurationMs?: number;
Expand Down
4 changes: 0 additions & 4 deletions plugins/baseten/src/stt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,8 @@ const defaultSTTOptions: Partial<BasetenSttOptions> = {
environment: 'production',
encoding: 'pcm_s16le',
sampleRate: 16000,
bufferSizeSeconds: 0.032,
enablePartialTranscripts: true,
partialTranscriptIntervalS: 0.5,
finalTranscriptMaxDurationS: 5,
audioLanguage: 'en',
languageDetectionOnly: false,
vadThreshold: 0.5,
vadMinSilenceDurationMs: 300,
vadSpeechPadMs: 30,
Expand Down
5 changes: 0 additions & 5 deletions plugins/baseten/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,11 @@ export interface BasetenSttOptions {
environment?: string;
encoding?: string;
sampleRate?: number;
bufferSizeSeconds?: number;

@devin-ai-integration devin-ai-integration Bot Aug 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Public option removal breaks consumers

TypeScript applications using any removed BasetenSttOptions property fail excess-property checks after upgrading. Public no-op options require deprecation before removal.

Prompt for agents 
Preserve source compatibility for the exported BasetenSttOptions interface in plugins/baseten/src/types.ts. Restore bufferSizeSeconds, partialTranscriptIntervalS, finalTranscriptMaxDurationS, prompt, and languageDetectionOnly as optional deprecated properties for a deprecation cycle, while leaving them unused at runtime. Regenerate plugins/baseten/etc/agents-plugin-baseten.api.md and add the required changeset documenting their deprecation. Remove them only in a planned breaking release.
Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

vadThreshold?: number;
vadMinSilenceDurationMs?: number;
vadSpeechPadMs?: number;
enablePartialTranscripts?: boolean;
partialTranscriptIntervalS?: number;
finalTranscriptMaxDurationS?: number;
audioLanguage?: string;
prompt?: string;
languageDetectionOnly?: boolean;
}

/**
Expand Down
Loading