Skip to content

chore(baseten): remove dead BasetenSttOptions fields and their defaults - #2391

Open
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-baseten-remove-dead-basetensttoptions-fields-88a847
Open

chore(baseten): remove dead BasetenSttOptions fields and their defaults#2391
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-baseten-remove-dead-basetensttoptions-fields-88a847

Conversation

@detail-app

@detail-app detail-app Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Description

Removed five unused fields from BasetenSttOptions in plugins/baseten/src/types.ts
(bufferSizeSeconds, partialTranscriptIntervalS, finalTranscriptMaxDurationS,
prompt, languageDetectionOnly) and the corresponding entries in
defaultSTTOptions in plugins/baseten/src/stt.ts. The auto-generated
etc/agents-plugin-baseten.api.md was regenerated to match.

Changes Made

  • Dropped bufferSizeSeconds, partialTranscriptIntervalS,
    finalTranscriptMaxDurationS, prompt, and languageDetectionOnly from the
    BasetenSttOptions interface — none had any production reader anywhere in the repo.
  • Removed the matching defaults from defaultSTTOptions (bufferSizeSeconds: 0.032,
    partialTranscriptIntervalS: 0.5, finalTranscriptMaxDurationS: 5,
    languageDetectionOnly: false); they were only merged into #opts but never
    read back.
  • Regenerated plugins/baseten/etc/agents-plugin-baseten.api.md via
    pnpm api:update so the public API report no longer lists the removed members.

Pre-Review Checklist

  • Build passes: All builds (lint, typecheck, tests) pass locally
  • AI-generated code reviewed: Removed unnecessary comments and ensured code quality
  • Changes explained: All changes are properly documented and justified above
  • Scope appropriate: All changes relate to the PR title, or explanations provided for why they're included
  • Video demo: N/A (no runtime behavior change; dead type fields and write-only defaults only)

Testing

  • Automated tests added/updated (if applicable)
  • All tests pass (pnpm vitest run for baseten; pnpm build, pnpm typecheck,
    pnpm lint, and pnpm api:check all green)
  • Make sure both restaurant_agent.ts and realtime_agent.ts work properly (for major changes) — N/A, baseten-only type cleanup

Additional Notes

  • bufferSizeSeconds was born dead: it was added in the original baseten plugin
    commit but never had a production reader.
  • partialTranscriptIntervalS, finalTranscriptMaxDurationS, prompt, and
    languageDetectionOnly were orphaned by PR Add aligned transcript support with word-level timing #984 ("Add aligned transcript support
    with word-level timing"), which dropped the streaming_params / whisper_params
    blocks in stt.ts that previously read them — the reads were removed but the
    type fields and defaults were left behind.
  • Other BasetenSttOptions fields (including the @deprecated modelId, which
    still has a live fallback code path in getWsUrl) and all BasetenLLMOptions /
    BasetenTTSOptions members were verified as living and kept.
  • AI tooling: Detail: Dead Code

History


Dead Code PRs can be configured here.

@detail-app
detail-app Bot requested a review from a team as a code owner August 31, 2026 21:18
@changeset-bot

changeset-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3b14260

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

environment?: string;
encoding?: string;
sampleRate?: number;
bufferSizeSeconds?: number;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Public option removal breaks consumers

TypeScript applications using any removed BasetenSttOptions property fail excess-property checks after upgrading. Public no-op options require deprecation before removal.

Prompt for agents
Preserve source compatibility for the exported BasetenSttOptions interface in plugins/baseten/src/types.ts. Restore bufferSizeSeconds, partialTranscriptIntervalS, finalTranscriptMaxDurationS, prompt, and languageDetectionOnly as optional deprecated properties for a deprecation cycle, while leaving them unused at runtime. Regenerate plugins/baseten/etc/agents-plugin-baseten.api.md and add the required changeset documenting their deprecation. Remove them only in a planned breaking release.
Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants