Skip to content

Delete files synchronously during snapshot expiration #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mkuchenbecker wants to merge 2 commits into from
Closed

Delete files synchronously during snapshot expiration #710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a33bf1
fix: delete files during snapshot expiration
mkuchenbecker Sep 2, 2026
5f1af8f
test: verify snapshot expiration deletes files
mkuchenbecker Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/spark/src/main/java/com/linkedin/openhouse/jobs/spark/Operations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ public void expireSnapshots(String fqtn, int maxAge, String granularity, int ver
* number of snapshots younger than the maxAge
*/
public void expireSnapshots(Table table, int maxAge, String granularity, int versions) {
ExpireSnapshots expireSnapshotsCommand = table.expireSnapshots().cleanExpiredFiles(false);
ExpireSnapshots expireSnapshotsCommand = table.expireSnapshots().cleanExpiredFiles(true);

// maxAge will always be defined
ChronoUnit timeUnitGranularity =
Expand Down
13 changes: 13 additions & 0 deletions apps/spark/src/test/java/com/linkedin/openhouse/jobs/spark/OperationsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
import org.apache.commons.lang3.tuple.Triple;
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.fs.Path;
import org.apache.iceberg.ExpireSnapshots;
import org.apache.iceberg.Schema;
import org.apache.iceberg.Snapshot;
import org.apache.iceberg.Table;
Expand Down Expand Up @@ -509,6 +510,18 @@ public void testOrphanFilesDeletionDeleteDataWhenDataManifestNotExists() throws
}
}

@Test
public void testExpireSnapshotsCleansExpiredFilesSynchronously() throws Exception {
Table table = Mockito.mock(Table.class);
ExpireSnapshots expireSnapshots =
Mockito.mock(ExpireSnapshots.class, Mockito.RETURNS_SELF);
Mockito.when(table.expireSnapshots()).thenReturn(expireSnapshots);

Operations.of(getSparkSession(), otelEmitter).expireSnapshots(table, 3, "DAYS", 0);

Mockito.verify(expireSnapshots).cleanExpiredFiles(true);
}

@Test
public void testSnapshotsExpirationMaxAge() throws Exception {
final String tableName = "db.test_es_maxage_java";
Expand Down
Loading