Delete files synchronously during snapshot expiration - #710
Closed
mkuchenbecker wants to merge 2 commits into
Closed
Delete files synchronously during snapshot expiration#710mkuchenbecker wants to merge 2 commits into
mkuchenbecker wants to merge 2 commits into
Conversation
Enable Iceberg's synchronous file cleanup when expiring snapshots so files are removed as part of the operation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Guard the synchronous cleanup setting by verifying that snapshot expiration configures Iceberg to clean expired files. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mkuchenbecker
marked this pull request as ready for review
September 2, 2026 20:05
mkuchenbecker
requested review from
abhisheknath2011,
maluchari and
teamurko
September 2, 2026 20:24
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing Done
git diff --check./gradlew :apps:spark:test --tests com.linkedin.openhouse.jobs.spark.OperationsTest(the repository's Gradle hook setup assumes.gitis a directory and fails in Git worktrees)Test is mostly a tautology.