Skip to content

fix(close_channel): error when no matching channel found #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bartok9 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(close_channel): error when no matching channel found #1094

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2156,9 +2156,18 @@ impl Node {
// dropping it. This lets `channel_reestablish` drive the recovery flow, which is
// especially important against LND peers that don't always handle force-closure
// error messages correctly.
}

Ok(())
Ok(())
} else {
log_error!(
self.logger,
"Failed to {} channel: no matching channel found for user_channel_id {} and counterparty {}",
if force { "force-close" } else { "close" },
user_channel_id,
counterparty_node_id
);
Err(Error::ChannelClosingFailed)

@tnull tnull Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should always at least log what/why it failed when we return an error.

}
}

/// Update the config for a previously opened channel.
Expand Down
Loading