Conversation
|
I've assigned @tnull as a reviewer! |
tnull
reviewed
Sep 14, 2026
| Ok(()) | ||
| Ok(()) | ||
| } else { | ||
| Err(Error::ChannelClosingFailed) |
Collaborator
There was a problem hiding this comment.
We should always at least log what/why it failed when we return an error.
| /// `UserChannelId` did not match any channel for the counterparty, silently | ||
| /// succeeding without initiating a close. | ||
| #[tokio::test(flavor = "multi_thread", worker_threads = 1)] | ||
| async fn close_unknown_user_channel_id_errors() { |
Collaborator
There was a problem hiding this comment.
I don't think the change is worth a dedicated test case, please drop it.
Bartok9
force-pushed
the
fix/close-channel-no-match-error
branch
2 times, most recently
from
September 16, 2026 12:44
20f0b54 to
d66df47
Compare
Closes lightningdevkit#1084 Previously close_channel and force_close_channel returned Ok(()) when no matching UserChannelId was found for the counterparty, silently succeeding without initiating a close. Now returns Err(ChannelClosingFailed), matching update_channel_config. AI-assisted: generated by Sera (Hermes Agent), verified manually. Tests compile; integration test requires bitcoind/electrs binaries (architecturally incompatible electrs binary in this cron environment, same failure affects all integration tests) Signed-off-by: Bartok9 <259807879+Bartok9@users.noreply.github.com>
Bartok9
force-pushed
the
fix/close-channel-no-match-error
branch
from
September 16, 2026 16:37
d66df47 to
0e2b867
Compare
Author
|
Thanks @tnull — applied both nits:
Tip 0e2b867. The earlier macos 1.85 failure was channel_full_cycle_force_close (Unexpected balance state in tests/common/mod.rs:632) after a splice+force-close path this PR does not change; main is green on the same parent (f375e4d). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close_channelandforce_close_channelreturnedOk(())when no matchingUserChannelIdwas found for the counterparty, silently succeeding without initiating a close. Now returnsErr(ChannelClosingFailed), matchingupdate_channel_config.Closes #1084
AI-assisted: generated by Sera (Hermes Agent), verified manually. Integration test compiles; runtime requires bitcoind/electrs binaries not available in this cron environment.
Agent-Owner:sera