Repository navigation
Fold the scan report into the server page - #73
Merged
Merged
Conversation
The scan report repeated the server page's scanner rows with the same status, date and evidence; only the request transcript and the per-level counts were its own. The server page now prints the counts per level in its status panel and "What the scanner asked" after its feature tables. The scanner page carries how the summary is counted and lists every requirement the scanner does not check. /mcp/servers/<id>/scan/ forwards to the server page; scan.json stays. - ScanTranscript.astro replaces ScanReport.astro; scan.astro removed - matrix "scan" link opens the server page's #scan section - spec 017 amended (FR-007 to FR-009); README, architecture, scanner docs Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TGqDwTwUQwBNWtbGzgXsYr
On the server page the ladder sits below the fold, so the check could run before the ladder started and catch a line mid-fade. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TGqDwTwUQwBNWtbGzgXsYr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Jan · project thread
What this changes
The scan report (
/mcp/servers/<id>/scan/) repeated the server page's scanner rows with the same status, date and evidence. Only the request transcript and the per-level counts were its own. This PR moves those parts to where they belong and removes the report page:scan.json, the data file and the scanner page. Servers with no OAuth or no scan get a short note in the same place./mcp/servers/<id>/scan/redirects to the server page (so does the older/scanner/<id>/).scan.jsonstays./mcp/servers/<id>/#scan.ScanTranscript.astroreplacesScanReport.astro. Spec 017 is amended (FR-007 to FR-009, tasks T11–T16). README,docs/architecture.mdanddocs/scanner.mdare updated.One edge case to know about: if a manual observation is newer than the scanner's, the row on the server page shows the manual status, while the per-level counts still come from the scanner's own observations (as they did on the report).
Before/after screenshots are in the project files under
review/scan-fold/.Code checklist
pnpm checkpasses.report-*baselines are deleted. Locally, all e2e tests in scanner, server-page and matrix pass except the screenshot comparisons, which fail on any page here because the local Chromium differs from CI's.Generated by Claude Code