Repository navigation
Review follow-up 6: the matrix on desktop (table first, revision once, no clipped groups) - #65
Merged
Merged
Conversation
The table comes straight after the head; the status key and the count sit under it, and the filters fold into one button on the head's meta line. The revision is named once. On wide screens the table fits the column: a group whose label outgrows its columns takes the label's width, so the clipped "Tra…" and the two groups hidden past the frame edge are gone. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KerMxC6ZiZWQwLScvy8Ym4
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KerMxC6ZiZWQwLScvy8Ym4
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KerMxC6ZiZWQwLScvy8Ym4
Generated by the screenshots workflow for #65.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KerMxC6ZiZWQwLScvy8Ym4
Collaborator
Author
|
CI on 79f0f97: the e2e tests pass now (the new baselines are in). The one red step is Lighthouse budgets on I checked whether this PR made
So I don't see a cause in this diff. I'm re-running the failed job once to check whether the score is just varying between runs. If it fails again, I'll treat it as a real regression and look further. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Jan · project thread
What this changes
Review follow-up 6, the matrix on desktop. Phones keep the follow-up 5 view; the only phone change is that the filter button moves into the head and the status key moves under the table.
Table first. The matrix comes straight after the head. The status key and the live count sit under the table, above the reading notes. "Filter and group" folds into one quiet button at the end of the head's meta line (as the standards map does); opened, it stays where it was and the form runs under the whole line.
The revision once. It is named only in the meta line ("Revision 2026-07-28 · current"). The lede says "the MCP Authorization specification", the link to the text reads "Specification text", and the published date shows only when it differs from the revision id (today they are the same date, so it said 2026-07-28 three times).
No more "Tra…". At 1440 px the table was 1344 px wide in a 1248 px frame: "Transport" was clipped at the frame edge and Delegation and Consent were hidden past it. On wide screens the table now fits the column. Its widths come from the group row: a group whose label is wider than its columns (
data-narrow, from an estimate of the label's length) takes the label's width, and the other columns share the rest, down to a 2.25rem floor below which the frame scrolls as before (about 1100 px and narrower). The island redoes the sums when a filter changes which groups are narrow. Feature columns go from 48 px to about 39 px at 1440 px.Tests. A new e2e test checks that at 1440 px the table fits its frame and no group label is clipped (it fails on main).
tasks.mdgets R-06.Screenshots
From
astro previewat 1440 px and 390 px (Pixel 7). "Below" is scrolled to the end of the table.The screenshots were committed once for stable URLs and removed in the next commit, so the squashed diff carries no images.
Code checklist
pnpm checkpasses.matrix-light/dark/phone.pngandstatus-shapes-*.pngregenerated through therefresh-screenshotslabel.🤖 Generated with Claude Code
https://claude.ai/code/session_01KerMxC6ZiZWQwLScvy8Ym4