Repository navigation
Review follow-up 5: the matrix on phones (All strip view, one group at a time) - #64
Merged
Merged
Conversation
…t a time) Below 40rem the matrix is read one way at a time. A row of plain anchors picks All or one requirement group through :target, so it works without JavaScript; the island records the choice as data-view with aria-current. All draws every requirement as a strip of small glyphs per server, sized with container units, with no sideways scroll. A group shows its own columns with two-line horizontal labels, a peek of the next column and scroll shadows. Desktop is unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NpUBtmwdEWareczX48koZj
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NpUBtmwdEWareczX48koZj
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NpUBtmwdEWareczX48koZj
Merged
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Jan · project thread
What this changes
Review follow-up 5. On a 390 px phone the matrix showed a 176 px server column, three of 23 columns and a header block about 600 px tall. Instead of squeezing the desktop table, phones (below 40rem) now read the matrix one way at a time. Desktop is unchanged (pixel-identical in the shots below).
A group picker of plain anchors. All, then one pill per requirement group with its count, above the table. Each pill is an anchor to itself, so
:targetpicks the view and it works without JavaScript; every group stays in the HTML. The island turns the choice intodata-viewwitharia-current, so switching keeps the scroll position and adds no history entry. A#mx-<group>link (or the back button) still selects a group.All: the whole atlas on one screen. Every requirement is a small glyph in a strip per server, the column width computed from the frame with container units (
cqi), so all 23 fit with no sideways scroll. Group boundaries are hairlines, and the groups row names them as far as they fit. The glyphs are a picture here (no 10 px tap targets); a group's view opens them. Names are one line with an ellipsis.A group: readable columns. Only that group's columns, chosen by one generated
nth-childrange per group (the groups are contiguous runs). Headers are two-line horizontal labels instead ofvertical-rl, about 80 px tall instead of 600. Columns are sized so two and a half are in view, so the next one always peeks in, with scroll shadows at the frame edges (a fixed shade plus a cover that scrolls with the table). Cells open their observation as before.Server column. 7rem on phones, names wrap to two lines and link to the server page, which is the transposed view. The access/auth chips are left to the server page on phones.
Tests. e2e: All fits without sideways scroll; a group shows only its columns with horizontal labels and comes back to All; the picker works without JavaScript; the 320 px sticky-column test now runs in a group view; the cell tests open the cell's group first.
tasks.mdgets R-05.Screenshots
From
astro previewof this branch at 1280 px and 390 px (Pixel 7), scrolled to the matrix.The screenshots were committed once for stable URLs and removed in the next commit, so the squashed diff carries no images.
Code checklist
pnpm checkpasses.matrix-phone.png(and possiblystatus-shapes-phone.png) change as intended and need therefresh-screenshotslabel; the desktop shots should not change.Generated by Claude Code