ci: Pin poetry to 1.8.5 in the release workflows - #56
Merged
Conversation
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
kinyoklion
marked this pull request as ready for review
September 10, 2026 15:55
joker23
approved these changes
Sep 10, 2026
This was referenced Sep 10, 2026
kinyoklion
pushed a commit
that referenced
this pull request
Sep 10, 2026
Installs poetry before `actions/setup-python` in both release workflows, matching `ci.yml`, so the release build keeps Python 3.9. - Fixes the `Install poetry` failure in `release-please.yml` and `manual-publish.yml` (latest occurrence: https://github.com/launchdarkly/python-server-sdk-otel/actions/runs/34501023236/job/102951560951) - No version changes: `poetry-version: "1.8.5"` and `python-version: 3.9` stay as they are - 1.2.1 was never published (PyPI is still at 1.2.0), so `Publish Package` needs a re-run once this merges **Requirements** - [ ] I have added test coverage for new or changed functionality - [x] I have followed the repository's [pull request submission guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests) - [x] I have validated my changes against all supported platform versions <details> <summary>Implementation details</summary> Root cause: with `setup-python` first, the poetry action's pipx install runs under the 3.9 interpreter that `setup-python` just provisioned — and `setup-python` upgrades pip in that interpreter (`Successfully installed pip-26.0.1` in the job log). pip 26 no longer supports 3.9, so pipx fails with `TypeError: dataclass() got an unexpected keyword argument 'slots'` (that kwarg is 3.10+). This is version-independent for poetry, which is why pinning `poetry-version: "1.8.5"` in #56 did not fix it. Why `ci.yml` stayed green: it installs poetry first, so pipx uses the runner image's interpreter — the 3.9 matrix job logs `installed package poetry 1.8.5, installed using Python 3.12.3` — and `setup-python` then provisions 3.9 for the steps that follow. This PR gives the release workflows the same ordering, so poetry itself runs on the image python while `poetry build` / `make docs` still execute against 3.9. Alternative rejected: bumping the release interpreter to 3.13 (#57, closed) — it works, but drops 3.9 from the release path unnecessarily. </details> Link to Devin session: https://app.devin.ai/sessions/27c11423375c4470807e81afc8567bb1 Open in Devin Desktop: https://app.devin.ai/desktop/session/27c11423375c4470807e81afc8567bb1?variant=devin <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Overview** > Reorders steps in **`manual-publish.yml`** and **`release-please.yml`** so **Install poetry** runs **before** `actions/setup-python`, matching **`ci.yml`**. > > This fixes release jobs that failed when poetry was installed via pipx after `setup-python` had upgraded pip on Python 3.9 (pip 26 + 3.9 incompatibility). Poetry now installs using the runner’s default interpreter; **Python 3.9** and **poetry 1.8.5** are unchanged for build/publish steps. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 19d346d. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins poetry to 1.8.5 in the release-please and manual-publish workflows so it works with the Python 3.9 these jobs set up.
abatilo/actions-poetrynow getspoetry-version: "1.8.5"in both workflows, matchingci.ymlImplementation details
Without the pin, the action installs the latest poetry, which no longer supports Python 3.9; both release jobs run
actions/setup-pythonwithpython-version: 3.9.ci.ymlalready pinned 1.8.5, so this makes the release paths consistent.No test coverage applicable (workflow-only change); verification happens when the workflows next run.
Requirements
Link to Devin session: https://app.devin.ai/sessions/ca8f5a045d134f84ac361aca7d527c04
Open in Devin Desktop: https://app.devin.ai/desktop/session/ca8f5a045d134f84ac361aca7d527c04?variant=devin
Requested by: @kinyoklion
Note
Overview
Pins Poetry 1.8.5 on the
abatilo/actions-poetrystep inmanual-publishandrelease-please, matchingci.yml.Both release jobs still use Python 3.9; without the pin, the action installs current Poetry, which no longer supports 3.9 and can break publish/release builds.
Reviewed by Cursor Bugbot for commit c04eba7. Bugbot is set up for automated code reviews on this repo. Configure here.