ci: install poetry before setup-python in release workflows - #58
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
kinyoklion
approved these changes
Sep 10, 2026
joker23
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installs poetry before
actions/setup-pythonin both release workflows, matchingci.yml, so the release build keeps Python 3.9.Install poetryfailure inrelease-please.ymlandmanual-publish.yml(latest occurrence: https://github.com/launchdarkly/python-server-sdk-otel/actions/runs/34501023236/job/102951560951)poetry-version: "1.8.5"andpython-version: 3.9stay as they arePublish Packageneeds a re-run once this mergesRequirements
Implementation details
Root cause: with
setup-pythonfirst, the poetry action's pipx install runs under the 3.9 interpreter thatsetup-pythonjust provisioned — andsetup-pythonupgrades pip in that interpreter (Successfully installed pip-26.0.1in the job log). pip 26 no longer supports 3.9, so pipx fails withTypeError: dataclass() got an unexpected keyword argument 'slots'(that kwarg is 3.10+). This is version-independent for poetry, which is why pinningpoetry-version: "1.8.5"in #56 did not fix it.Why
ci.ymlstayed green: it installs poetry first, so pipx uses the runner image's interpreter — the 3.9 matrix job logsinstalled package poetry 1.8.5, installed using Python 3.12.3— andsetup-pythonthen provisions 3.9 for the steps that follow. This PR gives the release workflows the same ordering, so poetry itself runs on the image python whilepoetry build/make docsstill execute against 3.9.Alternative rejected: bumping the release interpreter to 3.13 (#57, closed) — it works, but drops 3.9 from the release path unnecessarily.
Link to Devin session: https://app.devin.ai/sessions/27c11423375c4470807e81afc8567bb1
Open in Devin Desktop: https://app.devin.ai/desktop/session/27c11423375c4470807e81afc8567bb1?variant=devin
Note
Overview
Reorders steps in
manual-publish.ymlandrelease-please.ymlso Install poetry runs beforeactions/setup-python, matchingci.yml.This fixes release jobs that failed when poetry was installed via pipx after
setup-pythonhad upgraded pip on Python 3.9 (pip 26 + 3.9 incompatibility). Poetry now installs using the runner’s default interpreter; Python 3.9 and poetry 1.8.5 are unchanged for build/publish steps.Reviewed by Cursor Bugbot for commit 19d346d. Bugbot is set up for automated code reviews on this repo. Configure here.