Skip to content

fix: Log a non-string kind attribute as an error #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kinyoklion merged 1 commit into from
Nov 6, 2026
+2 −1
Merged

fix: Log a non-string kind attribute as an error #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ld_openfeature/impl/context_converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def to_ld_context(self, context: EvaluationContext) -> Context:
return self.__build_multi_context(context)

if kind is not None and not isinstance(kind, str):
logger.warning("'kind' was set to a non-string value; defaulting to user")
logger.error("'kind' was set to a non-string value; defaulting to user")
kind = 'user'

targeting_key = context.targeting_key
Expand Down
1 change: 1 addition & 0 deletions tests/test_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@ def test_logger_changes_should_cascade_to_evaluation_converter(provider: LaunchD

assert len(caplog.records) == 1
assert caplog.records[0].message == "'kind' was set to a non-string value; defaulting to user"
assert caplog.records[0].levelname == 'ERROR'


def test_track_without_context_does_not_send_an_event(provider: LaunchDarklyProvider):
Expand Down
Loading