Repository navigation
fix: Log a non-string kind attribute as an error - #76
Merged
Merged
Conversation
Co-Authored-By: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
keelerm84
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
OpenFeature provider spec (
OFP) Requirement 2.1.4.1 inlaunchdarkly/sdk-specs.Describe the solution you've provided
When an
EvaluationContexthas akindattribute that is not a string, the provider ignores it and builds ausercontext. OFP 2.1.4.1 says the provider MUST log an error in that case, and the README already says "An error message will be logged". The converter logged it as a warning, so this changeslogger.warningtologger.errorand the provider test now asserts the log level.Describe alternatives you've considered
None.
Additional context
The conversion behavior is unchanged; only the log level is different. Found during the weekly OpenFeature provider audit.
Link to Devin session: https://app.devin.ai/sessions/f7bc946afe8c41a28cf7f3f497fc8b9d
Open in Devin Desktop: https://app.devin.ai/desktop/session/f7bc946afe8c41a28cf7f3f497fc8b9d?variant=devin
SDK-3496
Note
Overview
Aligns logging with OpenFeature provider spec 2.1.4.1 and the README: when
EvaluationContexthas a non-stringkind, the converter still discards it and builds a user context, but now emitslogger.errorinstead oflogger.warning.The provider integration test
test_logger_changes_should_cascade_to_evaluation_converternow asserts the captured log record is at ERROR level (message unchanged).Reviewed by Cursor Bugbot for commit 42c82b8. Bugbot is set up for automated code reviews on this repo. Configure here.