Skip to content

build: point scm metadata at lance-format/lance-spark #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jackylee-ch wants to merge 2 commits into
base: main
Choose a base branch
from
Open

build: point scm metadata at lance-format/lance-spark #809

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae5c130
build: point scm metadata at lance-format/lance-spark
jackylee-ch Sep 7, 2026
6d6f450
build: stop appending child paths to inherited scm values
jackylee-ch Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,12 @@
</license>
</licenses>

<scm>
<connection>scm:git:git@github.com:lancedb/lance-spark.git</connection>
<developerConnection>scm:git:git@github.com:lancedb/lance-spark.git</developerConnection>
<url>git@github.com:lancedb/lance-spark.git</url>
<scm child.scm.connection.inherit.append.path="false"
child.scm.developerConnection.inherit.append.path="false"
child.scm.url.inherit.append.path="false">
<connection>scm:git:https://github.com/lance-format/lance-spark.git</connection>

@lance-gatekeeper lance-gatekeeper Bot Sep 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maven appends each child artifact ID to inherited SCM values by default, so these root values do not yield usable metadata for the artifacts this reactor publishes. On this head, ./mvnw -f lance-spark-3.5_2.13/pom.xml help:evaluate -Dexpression=project.scm.connection -q -DforceStdout returns scm:git:https://github.com/lance-format/lance-spark.git/lance-spark-3.5_2.13; GIT_TERMINAL_PROMPT=0 git ls-remote https://github.com/lance-format/lance-spark.git/lance-spark-3.5_2.13 HEAD then fails with repository not found. project.scm.url similarly becomes https://github.com/lance-format/lance-spark/lance-spark-3.5_2.13, rather than the intended browsable repository URL.

Please disable child-path appending on <scm> for connection, developerConnection, and url (the child.scm.*.inherit.append.path="false" attributes). I verified that this makes the same child resolve all three values exactly to the repository-level targets.

@jackylee-ch jackylee-ch Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified and fixed in 6d6f450. On the previous head lance-spark-3.5_2.13 resolved scm:git:https://github.com/lance-format/lance-spark.git/lance-spark-3.5_2.13, and git ls-remote on it returns Not Found. Disabling the append on all three fields makes root, base, version and bundle modules all resolve to the plain repository, and git ls-remote on that succeeds.

@lance-gatekeeper lance-gatekeeper Bot Sep 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 6d6f450: the SCM values now remain unchanged for root, base, versioned, and bundle POMs, and the HTTPS repository connection resolves successfully.

<developerConnection>scm:git:https://github.com/lance-format/lance-spark.git</developerConnection>
<url>https://github.com/lance-format/lance-spark</url>
<tag>HEAD</tag>
</scm>

Expand Down
Loading