build: point scm metadata at lance-format/lance-spark - #809
Open
jackylee-ch wants to merge 2 commits into
Open
Conversation
The scm connection, developerConnection and url still name lancedb and use an SSH string, while issueManagement above already names lance-format. Maven expects a browsable URL there, so every published POM carries an address that cannot be opened.
github-actions
Bot
added
the
chore
![lance-gatekeeper[bot]](https://avatars.githubusercontent.com/in/4433141?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lance-gatekeeper
Bot
added
the
K-changes
Maven appends each child artifact ID to inherited SCM fields by default, so every published module carried .../lance-spark.git/<artifactId>, which is not a repository. Disable the append for connection, developerConnection and url so the whole reactor publishes one repository-level SCM contract.
lance-gatekeeper
Bot
removed
the
K-changes
lance-gatekeeper
Bot
added
the
K-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<scm>still points atlancedb/lance-sparkover SSH; uselance-format/lance-sparkover HTTPSso the published POMs carry a browsable repository URL
Test plan
./mvnw -N help:evaluate -Dexpression=project.scm.url🤖 Generated with Claude Code