Repository navigation
fix: override exists methods for lance-namespace 0.11.1 - #184
Merged
Merged
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Implementations compiled against the 0.7.7 void methods do not override the 0.11 response methods, so callers hit the interface default.
geruh
force-pushed
the
fix/exists-response-0.11.1
branch
from
October 5, 2026 17:48
9b9bfa1 to
bf384cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds the six namespace implementations against lance-namespace 0.11.1 so
tableExistsandnamespaceExistsoverride the new response methods. Implementations compiled against0.7.7fail to override those methods when they run with core0.11.1, so callers hit the interface default.namespaceExistschecksdatabaseExistsand throwsNamespaceNotFoundExceptionwhen the database is absent.describeTablerejects that entry.tableExistsignores table format.describeTablerejects a non-Lance format.InternalExceptionorServiceUnavailableException.Testing
The Hive 3 consumer needed
hadoop-mapreduce-client-core2.7.1 becauseHive3ClientPoolloadsJobConf.TestUnityNamespacedid not run. That suite is JUnit 4 and this build has no vintage provider.