Skip to content

fix: override exists methods for lance-namespace 0.11.1 - #184

Merged
geruh merged 1 commit into
mainfrom
fix/exists-response-0.11.1
Oct 5, 2026
Merged

geruh merged 1 commit into
mainfrom
fix/exists-response-0.11.1

Conversation

@geruh

@geruh geruh commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

This PR builds the six namespace implementations against lance-namespace 0.11.1 so tableExists and namespaceExists override the new response methods. Implementations compiled against 0.7.7 fail to override those methods when they run with core 0.11.1, so callers hit the interface default.

  • Glue namespaceExists checks databaseExists and throws NamespaceNotFoundException when the database is absent.
  • Hive 2 and Hive 3 count a Lance metastore entry with no location as present. describeTable rejects that entry.
  • Polaris tableExists ignores table format. describeTable rejects a non-Lance format.
  • A denied or failed backend call propagates as InternalException or ServiceUnavailableException.

Testing

  • 51 contract tests passed.
  • The Java suite reported 220 tests, 22 skipped, and no failures.
  • All 51 packaged-consumer tests passed.

The Hive 3 consumer needed hadoop-mapreduce-client-core 2.7.1 because Hive3ClientPool loads JobConf. TestUnityNamespace did not run. That suite is JUnit 4 and this build has no vintage provider.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@github-actions github-actions Bot added bug Something isn't working java labels Oct 5, 2026
Implementations compiled against the 0.7.7 void methods do not override the 0.11 response methods, so callers hit the interface default.
@geruh
geruh force-pushed the fix/exists-response-0.11.1 branch from 9b9bfa1 to bf384cd Compare October 5, 2026 17:48
@geruh
geruh merged commit 424d302 into main Oct 5, 2026
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working java

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant