Repository navigation
fix: throw when an existence check fails - #875
Merged
Merged
Conversation
There was a problem hiding this comment.
Propagating failed existence checks prevents silent DROP TABLE IF EXISTS skips while preserving missing-object behavior. Version 0.4.2 includes the upstream existence-method fix, supporting removal of the temporary Glue fallback. The remaining risk is the absence of committed regression coverage for the changed error contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR throws when an existence check fails.
tableExistsreturned false on every exception, soDROP TABLE IF EXISTSskipped Glue tables whose 0.4.0 jar lefttableExistsunimplemented.namespaceExistscalleddescribeNamespaceonUNSUPPORTED.LanceNamespaceExceptionis thrown.Testing
- ./mvnw checkstyle:check spotless:check -pl lance-spark-base_2.12