Skip to content

fix: throw when an existence check fails - #875

Merged
geruh merged 1 commit into
lance-format:mainfrom
geruh:spkr
Oct 6, 2026
Merged

geruh merged 1 commit into
lance-format:mainfrom
geruh:spkr

Conversation

@geruh

@geruh geruh commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

This PR throws when an existence check fails. tableExists returned false on every exception, so DROP TABLE IF EXISTS skipped Glue tables whose 0.4.0 jar left tableExists unimplemented. namespaceExists called describeNamespace on UNSUPPORTED.

  • A missing table or namespace stays false. Any other LanceNamespaceException is thrown.
  • Spark depends on lance-namespace-impl 0.4.2.

Testing

- ./mvnw checkstyle:check spotless:check -pl lance-spark-base_2.12

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@github-actions github-actions Bot added the bug Something isn't working label Oct 6, 2026

@lance-gatekeeper lance-gatekeeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Gate recommendation: approve with a non-blocking risk.

Propagating failed existence checks prevents silent DROP TABLE IF EXISTS skips while preserving missing-object behavior. Version 0.4.2 includes the upstream existence-method fix, supporting removal of the temporary Glue fallback. The remaining risk is the absence of committed regression coverage for the changed error contract.

@lance-gatekeeper lance-gatekeeper Bot added K-approved Latest Gatekeeper recommendation permits acceptance. K-risk Latest Gatekeeper recommendation includes a non-blocking risk. and removed K-risk Latest Gatekeeper recommendation includes a non-blocking risk. K-approved Latest Gatekeeper recommendation permits acceptance. labels Oct 6, 2026
@geruh
geruh merged commit 668745b into lance-format:main Oct 6, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working K-approved Latest Gatekeeper recommendation permits acceptance. K-risk Latest Gatekeeper recommendation includes a non-blocking risk.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant