Repository navigation
fix(ci): store the ROCm verification logs as text instead of tarballs - #2266
Merged
Merged
Conversation
PR #2250 committed docs/benchmark_results/data/rocm-unified-engine-gfx1151-2026-10-08/guard/guard-logs.tar.gz and rounds/raw-logs.tar.gz without declaring them in scripts/ci/check_binary_assets.py, so the binary assets job has failed on main and on every PR since. Both archives hold small plain-text run logs (212 files), so they are unpacked in place (guard/logs/ and rounds/raw/, the path the report already cites for the raw logs) instead of being declared as a binary exception: text diffs and delta-compresses, and the guard's binary budget stays for assets that need it. The report's guard-log reference now points at guard/logs/.
inureyes
added
type:bug
3 tasks done
inureyes
added a commit
that referenced
this pull request
Oct 11, 2026
…rballs (#2267) ## Summary Follow-up to #2266. That PR cleared the `binary assets` failure from #2250 by unpacking the ROCm verification run logs into 212 text files. The logs are only opened to audit a run, so this keeps them archived instead: - Restores `docs/benchmark_results/data/rocm-unified-engine-gfx1151-2026-10-08/guard/guard-logs.tar.gz` and `rounds/raw-logs.tar.gz`, byte-identical to #2250's, and removes the unpacked `guard/logs/` and `rounds/raw/`. - Restores the report's reference to `guard/guard-logs.tar.gz`. - Adds a `DECLARED` rule to `scripts/ci/check_binary_assets.py` for `docs/benchmark_results/data/*.tar.gz` (raw per-run logs behind a committed benchmark report), 32 KB per file. ## Test plan - [x] `python3 scripts/ci/check_binary_assets.py`: OK, 11 declared binary files, 92.2 KB of the 256 KB budget - [x] `scripts/ci/check_binary_assets_test.sh`: all cases pass - [x] `scripts/insert_apache_header.py --check`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
binary assetsCI job has failed onmainsince PR #2250: it committeddocs/benchmark_results/data/rocm-unified-engine-gfx1151-2026-10-08/guard/guard-logs.tar.gz(15.1 KB) androunds/raw-logs.tar.gz(13.8 KB) without declaring them inscripts/ci/check_binary_assets.py, and every PR merged since carried the same failure.Both archives contain only plain-text run logs (212 files), so this unpacks them in place instead of adding a binary exception:
guard/guard-logs.tar.gzbecomesguard/logs/(the guard's per-run logs,guard/androunds/guard/inside it as archived).rounds/raw-logs.tar.gzbecomesrounds/raw/, the pathrocm-unified-engine-gfx1151-2026-10-08.mdalready cites for the rawmlxcel-bench-decodeoutput.guard/guard-logs.tar.gznow points atguard/logs/.Text diffs and delta-compresses in history, and the guard's 256 KB binary budget stays for assets that need to be binary. No log content changes.
Test plan
python3 scripts/ci/check_binary_assets.py:binary-assets: OK, 9 declared binary files, 63.3 KB of 256 KB budgetfilereports every unpacked file as text; none is matched by.gitignore