Repository navigation
fix(ci): keep the ROCm run logs archived and declare benchmark log tarballs - #2267
Merged
Merged
Conversation
…rballs PR #2266 unpacked docs/benchmark_results/data/rocm-unified-engine-gfx1151-2026-10-08/guard/guard-logs.tar.gz and rounds/raw-logs.tar.gz into 212 text files to clear the binary assets check. Those logs are only opened to audit a run, so they go back to the two original archives (byte-identical to PR #2250's), the report's reference is restored, and scripts/ci/check_binary_assets.py gains a rule for docs/benchmark_results/data/*.tar.gz with a 32 KB per-file ceiling.
inureyes
added
type:bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2266. That PR cleared the
binary assetsfailure from #2250 by unpacking the ROCm verification run logs into 212 text files. The logs are only opened to audit a run, so this keeps them archived instead:docs/benchmark_results/data/rocm-unified-engine-gfx1151-2026-10-08/guard/guard-logs.tar.gzandrounds/raw-logs.tar.gz, byte-identical to test(rocm): verify the unified engine on gfx1151 after the engine epic #2250's, and removes the unpackedguard/logs/androunds/raw/.guard/guard-logs.tar.gz.DECLAREDrule toscripts/ci/check_binary_assets.pyfordocs/benchmark_results/data/*.tar.gz(raw per-run logs behind a committed benchmark report), 32 KB per file.Test plan
python3 scripts/ci/check_binary_assets.py: OK, 11 declared binary files, 92.2 KB of the 256 KB budgetscripts/ci/check_binary_assets_test.sh: all cases passscripts/insert_apache_header.py --check