Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rotating selector now feeds a serial controller preparation phase. It snapshots the selected entities after movement, computes their nearest nodes, and publishes CMNs only at an explicit barrier. Moving an entity/ancestor, replacing the graph, destroying an entity or replacing the controller before publication rejects obsolete results. Completed off-graph results stay completed until their inputs change.
Stacked on #63 and requires the position revision API from labelle-toolkit/labelle-engine#916. Preparation is opt-in; no gameplay distance query is migrated or enabled by this PR.
Validation: 13 unit tests, 81 navigation specs, 13 new controller/engine integration tests, and all 20 Flying Platform test targets passed locally. Integration tests use the actual engine/controller with the engine's headless ECS backend. They cover the publication boundary, ancestor movement, fairness, cancellation, two allocation-failure stages, world/controller replacement, graph changes, destruction, node zero and off-graph completion.
Remaining before rollout: generation-qualified read-only entity queries, remaining legacy CMN writers/known-node updates, raw mutation and participant audits, the game's preparation driver and query/retry migration. Discovery and graph validation are not bounded by the search budget; no default budget, threading, WASM measurement or FPS claim is included. See
rfc/prepared-endpoint-implementation.mdandtests/integration/README.md.WASM review fix: reproduced the unsupported u64 atomic in the real controller lifecycle, then replaced it with a simulation-thread-owned u64 identity counter. Controller construction/destruction remain simulation-thread operations; future workers consume snapshots. Added
zig build wasm-checkand a CI step targeting wasm32 with atomics enabled, without requiring Emscripten. The check fails before the fix and passes afterward. Native unit/spec and engine integration tests pass. This fixes the reported compiler blocker; it is not a full web build or performance measurement.