Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
|
Build break for the web target, from measuring moca-tecnologia/flying-platform-labelle#1048 on this branch: Android emulator numbers for the stack are on the FP PR; wasm numbers will follow once this builds. |
|
Re-measured with
The lever that would change the numbers is in the game's participant selection (static entities on creation/graph change only; idle workers when they stop), not in this plugin — but a |
|
Final numbers for
|
|
Round 4 with 4.3.0-rc.1 (game
|
|
Review candidate for PR #65. Direct movers refresh their nearest endpoint after each movement step, with conservative reuse only while the nearest node remains proven. The optional registration index falls back to the canonical map if unavailable. Validation: unit/spec/WASM compile checks pass; 33 integration tests pass, including nearer-node crossing with a carried item and missing-index graph stability. No new performance measurements. |
Provide pure prepared distance/origin queries and bounded pending-only preparation. Ordinary endpoints require current CMNs; MovementNodes use current graph registration. Queries never resolve nearest nodes, repair endpoints or fall back to Euclidean distance.
Following the failed downstream performance review, graph walkers now publish current endpoints from their known route segments after movement, so ordinary movement no longer requires a nearest search. Direct walks refresh the nearest anchor after movement, reusing a previous winner only inside its proven nearest-node region; tracked attached items inherit the validated anchor. External movement, hierarchy changes and graph changes still invalidate immediately. Route anchors on long authored edges are accepted only after validating the point against the current segment; initial approach/direct placement retains the ordinary snap radius and vertical eligibility policy.
Static/unexplained pending endpoints use the deterministic bounded queue. Optional worker execution uses immutable snapshots and a whole-batch same-frame join; serial remains the default. Existing legacy query APIs remain separate.
Published integration prerelease: v4.3.0-rc.2 (requires engine v4.2.0-rc.1). These are installable release candidates, not performance acceptance. CI pins engine 21ea60c. Validation: 13 unit tests, 81 specs, 33 real-engine integration tests and WASM compile check pass; CI passes. Coverage includes low-fps walking without routine searches, long links, carrying/drop, direct movement, graph changes, fairness/cancellation and serial/worker publication equivalence.
Stacked on #64. Downstream #1048 now indexes destination candidates and shares scans across sources on the same prepared node. Revised serial performance and device/gameplay acceptance remain pending; the previous revision failed performance acceptance.
The optional registration array now falls back to the canonical registration map when unavailable, without forcing graph rebuilds. Regression coverage includes switching direct-mover anchors within the old snap radius, carried items, and unchanged graph epochs with a missing fast index.