Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bounded endpoint preparation must continue past the previous batch instead of repeatedly selecting newly invalidated low-ID entities. This adds world-local selection scratch that chooses a deterministic rotating batch from current ECS-derived pending identities. View order, duplicate membership and deletion of the cursor entity do not change the policy.
Stacked on #62. The cursor advances at the caller's publication barrier after the complete batch is processed; rejected stale results consume their turn too. Allocation failure leaves an empty batch without moving the cursor. There is no default budget or persistent authoritative pending queue.
This is selection machinery, not complete serial preparation. Controller participant discovery, snapshots, searches and CMN publication remain to be wired. Discovery costs O(candidate count × budget), so bounding search count is not a frame-time guarantee; measure the complete pipeline before choosing a budget. See
rfc/prepared-endpoint-implementation.md.Validation:
zig build test specpassed (13 unit tests, 81 navigation specs). Five new cases cover fairness, wrap/deletion/insertion, duplicate views, OOM, empty/zero-budget batches and all permutations of a small candidate set. All 20 Flying Platform test targets passed with the local dependency overrides.