Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepared matching needs immediate freshness checks without scanning graph inputs or rediscovering participants every frame. Add watched graph dependency revisions, indexed position freshness, membership notifications and a coalesced pending set in the world revision tracker. Shared position/hierarchy mutations enqueue affected participants without allocation; publication acknowledges only the matching revision. Raw backend membership writes require the documented notification companion.
Add a world-owned snapshot executor with one persistent worker plus the main thread. It joins the whole batch before returning, uses disjoint result ranges and falls back to the same serial callback on unsupported targets or spawn failure. Jobs must contain immutable snapshots and no live ECS access.
Stacked on #916. The pending set has one simulation-thread consumer per world; the executor is submitted from that thread. Validation: 1,517 engine tests and serial/threaded emscripten object compile probes pass. Pathfinder integration checks identical per-frame publication against the serial reference. Worker execution remains opt-in downstream; device performance is not yet established.