Repository navigation
fix(guard): keep only iOS whole after a one-letter prefix (#905) - #906
Conversation
The lowercase-leading acronym rule kept any one-letter lowercase prefix glued to the capitals after it, so xSDLConfig read as xSDL|Config and pWGPUDevice as pWGPU|Device, and neither backend name was reported. Restrict the exception to the literal iOS it exists for. Other prefixes are ordinary camelCase again (x|SDL|Config).
|
Warning Review limit reachedNext included review available in 3 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 100 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
A word ending in `i` before a generic OS (multiOSConfig) spells the same letters as getiOSConfig, so the guard reads it as iOS too. It cannot tell the two apart, and a false finding is cheaper than a missed platform name. Document the trade-off and the workaround (multi_os_config), and pin it with a test.
Closes #905.
The tokenizer's lowercase-leading acronym rule kept any one-letter lowercase prefix glued to the capitals after it. So
xSDLConfigread asxSDL|Config,pWGPUDeviceaspWGPU|Device, and neither backend name was reported.This restricts the exception to the literal
iOSit exists for. Other prefixes are ordinary camelCase again (x|SDL|Config).iOSConfig,iOsand the embedded forms from #903 keep working.Tests: new cases
xSDLConfig,pWGPUDeviceandiSDLPath.zig build test-guardpasses 17/17, andsrc/stays clean with the current allowlist.The same fix goes to the labelle-cli core guard, where this guard came from (companion PR).
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.