Repository navigation
Add optional shared window cursor controls - #82
Merged
Merged
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This was referenced Oct 12, 2026
Merged
apotema
marked this pull request as ready for review
October 13, 2026 08:20
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional cursor controls to the shared window interface so game code can hide the system pointer for its own artwork without importing a backend.
CursorControls.fromWindowadapts the optionalsetCursorVisible(bool) boolandisCursorOverWindow() booldeclarations into callbacks for the engine host to bind. Missing declarations safely return false; existing window backends and the required contract remain unchanged. The visibility result tells callers whether it is safe to draw a replacement pointer.Validation:
zig build test --summary allpassed 230/230 tests, including forwarding, unavailable-backend and partial-backend cases.Part of labelle-toolkit/labelle-bgfx#204. Platform implementation: labelle-toolkit/labelle-bgfx#205. Companion engine and assembler changes expose and bind these controls for game scripts. Merge/release this core change before the engine companion.
Companion PRs: core #82, engine #915, assembler #820, bgfx #205.