Skip to content

Add optional shared window cursor controls - #82

Merged
apotema merged 1 commit into
mainfrom
feat/shared-cursor-controls
Oct 13, 2026
Merged

apotema merged 1 commit into
mainfrom
feat/shared-cursor-controls

Conversation

@apotema

@apotema apotema commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Add optional cursor controls to the shared window interface so game code can hide the system pointer for its own artwork without importing a backend.

CursorControls.fromWindow adapts the optional setCursorVisible(bool) bool and isCursorOverWindow() bool declarations into callbacks for the engine host to bind. Missing declarations safely return false; existing window backends and the required contract remain unchanged. The visibility result tells callers whether it is safe to draw a replacement pointer.

Validation: zig build test --summary all passed 230/230 tests, including forwarding, unavailable-backend and partial-backend cases.

Part of labelle-toolkit/labelle-bgfx#204. Platform implementation: labelle-toolkit/labelle-bgfx#205. Companion engine and assembler changes expose and bind these controls for game scripts. Merge/release this core change before the engine companion.

Companion PRs: core #82, engine #915, assembler #820, bgfx #205.

@coderabbitai

coderabbitai Bot commented Oct 12, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T08:21:26.053677Z 3983336 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant