Repository navigation
Bind shared engine cursor controls in generated startup - #820
Merged
Merged
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bind the engine's shared cursor API to the host window during generated startup, before scripts run. Both loop and callback paths emit
g.bindCursorWindow(window)behind a comptime declaration check, preserving compatibility with older engines. The companion engine/core adapters safely handle backends without cursor support.Includes startup-order tests, updated desktop/web/mobile golden outputs, and a compile-and-run test of the emitted statement against old and new engine surfaces. Animation registration remains first in startup.
Validation:
zig build test --summary all -j4).zig build test-cursor --summary all -j4: 92/92 passed, including the new emitted-code compilation test.Part of labelle-toolkit/labelle-bgfx#204. Core contract: labelle-toolkit/labelle-core#82. Backend implementation: labelle-toolkit/labelle-bgfx#205. Requires the companion engine API to activate cursor binding; older engines continue unchanged. Release all companions and regenerate the consuming game to use the shared API.
Companion PRs: core #82, engine #915, assembler #820, bgfx #205.