app: Name what already-open agents pick up on the done step by nortonandreev · Pull Request #1881 · kurrent-io/kcap-cli

nortonandreev · 2026-10-23T12:28:10Z

Closes #1854 — AI-4263

What & why

The done step said "Agents you already have open pick this up when they next start", without saying what is picked up. It now gives the reason and the action as two sentences: "Agents load new hooks at startup. Restart any agent you already have open." Workspace and local setups get the same line.

Where to look

The line is hidden when setup turned on no recording, or when the shell can't find kcap (that case has its own note), since there is nothing for an agent to pick up. The header and import copy are #1831's.

Verification

DoneStepViewModelTests 9/9, OnboardingAccessibilityTests 1/1, WizardSimpleStepsTests 22/22 passed. Headless renders:

	Before	After
Workspace
Local
No recording

Summary by CodeRabbit

New Features
- The onboarding completion screen now shows when workspace setup is preparing, ready, or needs attention.
- You can retry setup if the daemon is unavailable or workspace registration has not completed.
- Dashboard and workspace links are available only when the current workspace is ready.
- A restart notice appears when capture requires restarting the app.
Bug Fixes
- Readiness checks now apply to the current workspace, preventing an earlier workspace’s status from enabling links.

Hooks load when an agent starts, so the line says that agents already open start sending sessions to the workspace (or recording on the machine, in local mode) after a restart. It is hidden when setup turned on no recording.

linear-code · 2026-10-23T12:28:16Z

AI-4263

coderabbitai · 2026-10-23T12:28:19Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: c7147018-7787-4ce0-b784-ac1377c98bf1

📥 Commits

Reviewing files that changed from the base of the PR and between d1f1dc3 and d2f4168.

📒 Files selected for processing: 7

src/Capacitor.App/App.axaml.cs
src/Capacitor.App/Services/Onboarding/WizardComposition.cs
src/Capacitor.App/ViewModels/Onboarding/DoneStepViewModel.cs
src/Capacitor.App/ViewModels/Onboarding/WorkspaceReadiness.cs
src/Capacitor.App/Views/Onboarding/DonePaneView.axaml
test/Capacitor.App.Tests.Unit/DoneStepViewModelTests.cs
test/Capacitor.App.Tests.Unit/WizardCompositionTests.cs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The onboarding Done step now tracks workspace readiness, prepares the daemon, and reports CLI setup. Workspace and dashboard links remain unavailable until readiness is confirmed. The step also displays preparation status, failure details, retry controls, and a restart notice.

Changes: Onboarding readiness and reporting

Layer / File(s)	Summary
Track and present workspace readiness `src/Capacitor.App/ViewModels/Onboarding/WorkspaceReadiness.cs`, `src/Capacitor.App/ViewModels/Onboarding/DoneStepViewModel.cs`, `src/Capacitor.App/Views/Onboarding/DonePaneView.axaml`, `test/Capacitor.App.Tests.Unit/DoneStepViewModelTests.cs`	The Done step tracks readiness for the current workspace and gates workspace and dashboard links until ready. It displays preparation and failure states, provides a retry command, and shows a restart notice when capture is promised. Tests cover readiness, retries, URL changes, and restart-line visibility.
Prepare the daemon and report CLI setup `src/Capacitor.App/Services/Onboarding/WizardComposition.cs`, `src/Capacitor.App/App.axaml.cs`, `test/Capacitor.App.Tests.Unit/WizardCompositionTests.cs`	Wizard composition waits for daemon work, ensures the daemon when applicable, and reports CLI setup after readiness. The app resolves a fresh server lane for reporting, with a 30-second timeout. Composition tests cover successful reporting and an unavailable CLI path.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature · Severity of issue fixed: Low

Sequence Diagram(s)

sequenceDiagram
  participant DoneStepViewModel
  participant WizardComposition
  participant ReportWizardCliSetupAsync
  participant FreshServerLaneAsync
  DoneStepViewModel->>WizardComposition: Request workspace preparation
  WizardComposition->>WizardComposition: Wait for daemon work and ensure daemon when applicable
  WizardComposition->>ReportWizardCliSetupAsync: Report CLI setup after daemon readiness
  ReportWizardCliSetupAsync->>FreshServerLaneAsync: Resolve a fresh server lane
  FreshServerLaneAsync-->>ReportWizardCliSetupAsync: Return lane or no server
  ReportWizardCliSetupAsync-->>WizardComposition: Return report success
  WizardComposition-->>DoneStepViewModel: Return workspace readiness

Possibly related issues

Issue 1854: The Done step now states that agents must restart to load newly installed hooks.

Suggested reviewers: alexeyzimarev, inok

Merge Risk: ⚪ Minimal · up to d2f41

The Done step is mergeable after normal checks. The remaining edge case requires changing servers twice during setup and is recoverable by selecting the server again.

Pre-merge checks: 3 · 2

Failed checks: 2 warnings

Check name	Status	Explanation	Resolution
Out of Scope Changes check		The pull request also adds workspace registration and daemon-readiness behavior that is not required by issue `#1854`. `WizardComposition` now prepares the daemon and reports CLI setup. `DoneStepViewMod…	Remove the unrelated daemon preparation, CLI setup reporting, server-lane changes, readiness state, link gating, retry UI, and their tests from this pull request, or move them to a pull request with a directly linked coding requirement. Ret…
Docstring Coverage		Docstring coverage is 29.63% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 27 functions across 6 files. (1 skipped: …	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 3 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly describes the main user-facing change: naming what already-open agents pick up on the onboarding done step.
Linked Issues check		Issue `#1854` requires the done-step line to name what an existing agent picks up, state when it applies, and remain readable on its own. `DoneStepViewModel.RestartLine` now says, “Agents load new hooks…

Full details: Linked Issues check

Explanation

Issue #1854 requires the done-step line to name what an existing agent picks up, state when it applies, and remain readable on its own. DoneStepViewModel.RestartLine now says, “Agents load new hooks at startup. Restart any agent you already have open.” The line applies to both workspace and local setups. It is hidden when no recording is enabled or the path hazard blocks capture. DoneStepViewModelTests covers the visibility and wording cases.

Full details: Out of Scope Changes check

Explanation

The pull request also adds workspace registration and daemon-readiness behavior that is not required by issue #1854. WizardComposition now prepares the daemon and reports CLI setup. DoneStepViewModel now gates workspace and dashboard links, handles retry and failure states, and tracks WorkspaceReadiness. App adds reporting and fresh server-lane handling. The added WizardCompositionTests verify this separate behavior. These changes exceed the requested done-step wording change.

Resolution

Remove the unrelated daemon preparation, CLI setup reporting, server-lane changes, readiness state, link gating, retry UI, and their tests from this pull request, or move them to a pull request with a directly linked coding requirement. Retain the #1854 restart wording and focused tests.

Full details: Docstring Coverage

Explanation

Docstring coverage is 29.63% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 27 functions across 6 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

qodo-code-review · 2026-10-23T12:28:46Z

PR Summary by Qodo

Clarify when already-open agents begin recording after setup

✨ Enhancement 🧪 Tests 🕐 10-20 Minutes

AI Description

• Explain that new hooks take effect when already-open agents restart.
• Name the recording destination for workspace and local setups.
• Hide the note when setup added no usable recording connection.

Diagram

graph TD
  F["Setup facts"] --> C{"Capture available?"} -->|Yes| M{"Local mode?"} -->|Yes| L["Machine restart note"] --> V["Done pane"]
  M -->|No| R["Workspace restart note"] --> V
  C -->|No| H["Hide restart note"] --> V

High-Level Assessment

Keep the note derived from existing done-step facts and bind it through the view model. This follows the pane’s existing conditional-text pattern; hardcoding both variants and their visibility in the view would split the decision across layers.

Files changed (3) +28 / -2

Enhancement (2) +8 / -2

DoneStepViewModel.csDerive a destination-specific restart note +6/-0

Derive a destination-specific restart note
• Adds RestartLine to explain when newly installed hooks take effect. It names the machine in local mode or the workspace otherwise, and returns null when no usable recording connection was added.
src/Capacitor.App/ViewModels/Onboarding/DoneStepViewModel.cs

DonePaneView.axamlBind and conditionally show the restart note +2/-2

Bind and conditionally show the restart note
• Replaces the ambiguous static line with the view-model text and hides the text block when that text is absent.
src/Capacitor.App/Views/Onboarding/DonePaneView.axaml

Tests (1) +20 / -0

DoneStepViewModelTests.csCover restart-note destinations and visibility +20/-0

Cover restart-note destinations and visibility
• Tests workspace and local wording, plus suppression when recording is empty or a path hazard blocks capture.
test/Capacitor.App.Tests.Unit/DoneStepViewModelTests.cs

qodo-code-review · 2026-10-23T12:29:45Z

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can reply 'qodo' on any finding to push back, ask questions, or dig deeper

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

nortonandreev · 2026-10-23T13:27:08Z

@CodeRabbit approve

coderabbitai · 2026-10-23T13:27:24Z

✅ Action performed

Comments resolved and changes approved.

Closes #1853 — AI-4262 Stacked on #1881 (same done-step row); retargets to `main` once that merges. ## What & why **Open your workspace** opened the dashboard before the server had the cli-setup report, which the app sent only after setup closed, so the website offered a CLI download the app already includes. The Done step now brings the daemon up and sends the report first, showing "Getting your workspace ready…" until it lands. If either fails, a warning card says why and offers **Try again**. The report is bounded at 30 s, so a silent server never leaves a spinner. ## Where to look Ready is never revoked once reached. A failed daemon run is repeated only on Try again, so a declined service takeover is not asked again. No website change is needed: kcap-server clears its install-cli step on `POST /api/users/me/cli-setup`. ## Verification Full `Capacitor.App.Tests.Unit` after the rebase: 4,245 passed, 10 skipped, 0 failed. Headless renders of the real Done view: | | Workspace | Local | |---|---|---| | Before | <img src="https://raw.githubusercontent.com/kurrent-io/kcap-cli/9fe9ce4f91025c497885a36ce7219fcf9b303d3e/1853/before-cloud.png" width="340"> | <img src="https://raw.githubusercontent.com/kurrent-io/kcap-cli/9fe9ce4f91025c497885a36ce7219fcf9b303d3e/1853/before-local.png" width="340"> | | Preparing | <img src="https://raw.githubusercontent.com/kurrent-io/kcap-cli/9fe9ce4f91025c497885a36ce7219fcf9b303d3e/1853/after-cloud-preparing.png" width="340"> | <img src="https://raw.githubusercontent.com/kurrent-io/kcap-cli/9fe9ce4f91025c497885a36ce7219fcf9b303d3e/1853/after-local-preparing.png" width="340"> | | Ready | <img src="https://raw.githubusercontent.com/kurrent-io/kcap-cli/9fe9ce4f91025c497885a36ce7219fcf9b303d3e/1853/after-cloud-ready.png" width="340"> | <img src="https://raw.githubusercontent.com/kurrent-io/kcap-cli/9fe9ce4f91025c497885a36ce7219fcf9b303d3e/1853/after-local-ready.png" width="340"> | | Report failed | <img src="https://raw.githubusercontent.com/kurrent-io/kcap-cli/9fe9ce4f91025c497885a36ce7219fcf9b303d3e/1853/after-cloud-unreported.png" width="340"> | <img src="https://raw.githubusercontent.com/kurrent-io/kcap-cli/9fe9ce4f91025c497885a36ce7219fcf9b303d3e/1853/after-local-unreported.png" width="340"> | | Daemon not running | <img src="https://raw.githubusercontent.com/kurrent-io/kcap-cli/9fe9ce4f91025c497885a36ce7219fcf9b303d3e/1853/after-cloud-daemon-not-running.png" width="340"> | |

nortonandreev · 2026-10-23T13:59:45Z

@CodeRabbit approve

coderabbitai · 2026-10-23T14:10:10Z

✅ Action performed

Comments resolved. CodeRabbit has already approved this PR, so no new approval was submitted.

app: Name what already-open agents pick up on the done step

ed66de5

Hooks load when an agent starts, so the line says that agents already open start sending sessions to the workspace (or recording on the machine, in local mode) after a restart. It is hidden when setup turned on no recording.

nortonandreev mentioned this pull request Oct 23, 2026

app: Register the CLI before setup opens the dashboard #1882

Merged

nortonandreev self-assigned this Oct 23, 2026

nortonandreev added 2 commits October 23, 2026 16:14

app: Split the done step's restart line into the reason and the action

f790dd0

app: Name the agent in the done step's restart line

d8fd310

coderabbitai Bot previously approved these changes Oct 23, 2026

View reviewed changes

nortonandreev dismissed coderabbitai[bot]’s stale review via d2f4168 October 23, 2026 13:59

coderabbitai Bot approved these changes Oct 23, 2026

View reviewed changes

nortonandreev merged commit cf5c781 into main Oct 23, 2026
12 checks passed

nortonandreev deleted the norton/ai-4263-done-step-restart-line branch October 23, 2026 15:02

coderabbitai Bot mentioned this pull request Oct 23, 2026

app: Rework the setup Ready step and sign-in from the website #1884

Merged

Navigation Menu

Repository navigation

app: Name what already-open agents pick up on the done step - #1881

app: Name what already-open agents pick up on the done step#1881
nortonandreev merged 4 commits into
mainfrom
norton/ai-4263-done-step-restart-line

nortonandreev commented Oct 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

linear-code Bot commented Oct 23, 2026

Uh oh!

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading

Sequence Diagram(s)

Uh oh!

qodo-code-review Bot commented Oct 23, 2026

Uh oh!

qodo-code-review Bot commented Oct 23, 2026

Uh oh!

nortonandreev commented Oct 23, 2026

Uh oh!

coderabbitai Bot commented Oct 23, 2026

Uh oh!

nortonandreev commented Oct 23, 2026

Uh oh!

coderabbitai Bot commented Oct 23, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

nortonandreev commented Oct 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What & why

Where to look

Verification

Summary by CodeRabbit

Uh oh!

linear-code Bot commented Oct 23, 2026

Uh oh!

coderabbitai Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Sequence Diagram(s)

Uh oh!

qodo-code-review Bot commented Oct 23, 2026

PR Summary by Qodo

Uh oh!

qodo-code-review Bot commented Oct 23, 2026

Code Review by Qodo

Great, no issues found!

Uh oh!

nortonandreev commented Oct 23, 2026

Uh oh!

coderabbitai Bot commented Oct 23, 2026

Uh oh!

nortonandreev commented Oct 23, 2026

Uh oh!

coderabbitai Bot commented Oct 23, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

nortonandreev commented Oct 23, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading