Repository navigation
chore: standardize copyright boilerplate and enforce with CI - #765
Conversation
Signed-off-by: Prachi01Yadav <archeyyadav111@gmail.com>
|
🎉 Welcome to the Kubeflow SDK! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
|
/ok-to-test |
Signed-off-by: Prachi01Yadav <archeyyadav111@gmail.com>
Signed-off-by: Prachi01Yadav <archeyyadav111@gmail.com>
Co-authored-by: Tariq Hasan <mmtariquehsn@gmail.com> Signed-off-by: Prachi Yadav <archeyyadav111@gmail.com>
Signed-off-by: Prachi01Yadav <archeyyadav111@gmail.com>
|
@Prachi01Yadav Are you still working on the PR or do we find new contributors to finish the PR? |
hi @tariq-hasan sorry for the delay....had my mid sems going on...yes im still on this, will update the workflow push the changes shortly |
Signed-off-by: Prachi01Yadav <archeyyadav111@gmail.com>
|
@tariq-hasan updated the workflow to use the composite action and removed the vendored files, ready for re review :)) |
andreyvelich
left a comment
andreyvelich
left a comment
There was a problem hiding this comment.
Thanks for this @Prachi01Yadav!
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…w#765) * chore: standardize copyright boilerplate and enforce with CI Signed-off-by: Prachi01Yadav <archeyyadav111@gmail.com> * style: fix ruff lint and format issues in vendored boilerplate.py Signed-off-by: Prachi01Yadav <archeyyadav111@gmail.com> * style: fix ruff format issue with multi-line string Signed-off-by: Prachi01Yadav <archeyyadav111@gmail.com> * Update hack/Dockerfile.spark-e2e-runner Co-authored-by: Tariq Hasan <mmtariquehsn@gmail.com> Signed-off-by: Prachi Yadav <archeyyadav111@gmail.com> * ci: add concurrency block to boilerplate workflow Signed-off-by: Prachi01Yadav <archeyyadav111@gmail.com> * refactor: use reusable verify-boilerplate action from kubeflow/testing Signed-off-by: Prachi01Yadav <archeyyadav111@gmail.com> --------- Signed-off-by: Prachi01Yadav <archeyyadav111@gmail.com> Signed-off-by: Prachi Yadav <archeyyadav111@gmail.com> Co-authored-by: Tariq Hasan <mmtariquehsn@gmail.com> Signed-off-by: digvijay-y <144053736+digvijay-y@users.noreply.github.com>
4 participants
Fixes #566 Replaces #568
What this PR does
-Adds the missing Apache 2.0 copyright headers to 46 files across the repo, and sets up CI to catch any missing headers going forward.
For CI, we're using the reusable composite action from kubeflow/testing#1070 instead of vendoring the script , keeps things clean and in sync.
Changes:
-Added copyright headers to 22 Python files, 13 workflow files, and a bunch of YAML configs + a Dockerfile
-Added code-quality-check.yaml workflow using kubeflow/testing/.github/actions/verify-boilerplate
-Removed the vendored hack/boilerplate/ (boilerplate.py + boilerplate.sh.txt) since the composite action handles it now
-Removed the verify-boilerplate Makefile target (was referencing the vendored script)