Repository navigation
chore: add boilerplate enforcement - #568
Ashvatthaa wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🎉 Welcome to the Kubeflow SDK! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
Signed-off-by: Ashvatthaa <ashvatthaaj@gmail.com>
ea45214 to
384de33
Compare
|
@Electronic-Waste Hi , I've addressed the requested changes and updated my PR. All required changes from my side have been completed. The remaining workflows are awaiting maintainer approval. I'd appreciate it if you could review the PR and approve the workflows as soon as possible. Thank you! |
| verify-boilerplate: ## Verify copyright boilerplate headers in source files. | ||
| @python3 hack/boilerplate/boilerplate.py --base-ref "$${TARGET_BRANCH:-main}" |
There was a problem hiding this comment.
Thanks for this work @Ashvatthaa!
Can we re-use @tariq-hasan's script instead of copying it in Kubeflow SDK?
https://github.com/kubeflow/trainer/blob/master/hack/boilerplate/boilerplate.py
Ideally, we need to move those scripts to the common repo.
cc @nsingla
There was a problem hiding this comment.
Sure, that make the work simple
|
Hi @Ashvatthaa! Have you been able to address the comments? I am happy to pick up the work and get it completed. |
|
@tariq-hasan Please can you help to finalize this PR, so we validate the boilerplate? |
|
Hi @tariq-hasan and @andreyvelich, Thanks for the feedback. I looked into the Trainer implementation and noticed it has diverged significantly from the SDK version. Before I make further changes, could you clarify whether you'd prefer: adapting the Trainer boilerplate.py into the SDK repository, or I'm happy to update the PR in whichever direction you recommend. |
@Ashvatthaa Let's try to use Trainer as a baseline script to verify SDK boilerplates. |
|
@Ashvatthaa Are you still working on this issue? |
|
@Ashvatthaa Given that we migrated @tariq-hasan's script to this common repo, can you update your PR to re-use it please? |
|
Resolved in: #765 (review) |
|
@andreyvelich: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Summary
This PR standardizes the repository's Apache 2.0 copyright boilerplate and adds automated boilerplate verification to ensure consistent copyright headers across the codebase.
Related Issue: Issue #566
Fixes #566
What changed
hack/boilerplate/.Validation
python hack/boilerplate/boilerplate.py --base-ref mainpython -m pytest .github/scripts/test_scripts.py -vpython -m py_compileon the modified Python filesgit diff --check