Skip to content

fix(breadcrumbs): close result dropdown when no hidden items (#DS-4578) #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NikGurev merged 2 commits into from
Jul 2, 2026
Merged

fix(breadcrumbs): close result dropdown when no hidden items (#DS-4578) #1675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b49ac1
fix(breadcrumbs): close result dropdown when no hidden items (#DS-4578)
NikGurev Jul 1, 2026
923b286
chore: after review
NikGurev Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/components/breadcrumbs/breadcrumbs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import { outputToObservable, takeUntilDestroyed, toObservable } from '@angular/c
import { RouterLink } from '@angular/router';
import { KbqButton, KbqButtonModule, KbqButtonStyles } from '@koobiq/components/button';
import { KbqComponentColors, KbqDefaultSizes, PopUpPlacements } from '@koobiq/components/core';
import { KbqDropdownModule } from '@koobiq/components/dropdown';
import { KbqDropdownModule, KbqDropdownTrigger } from '@koobiq/components/dropdown';
import { KbqIconModule } from '@koobiq/components/icon';
import {
KbqOverflowItem,
Expand Down Expand Up @@ -209,6 +209,7 @@ export class KbqBreadcrumbs {
protected readonly items = contentChildren<KbqBreadcrumbItem>(forwardRef(() => KbqBreadcrumbItem));

private readonly breadcrumbsResult = viewChild('breadcrumbsResult', { read: ElementRef });
private readonly resultDropdownTrigger = viewChild('breadcrumbsResult', { read: KbqDropdownTrigger });
private readonly result = viewChild(KbqOverflowItemsResult);
private readonly overflowItems = viewChildren<KbqOverflowItem>(forwardRef(() => KbqOverflowItem));
private readonly overflowItemsDir = viewChild(KbqOverflowItems);
Expand Down Expand Up @@ -292,6 +293,7 @@ export class KbqBreadcrumbs {
const hideResultIfAllVisible = () => {
if (allVisibleItems.length === items.length) {
result?.hide();
this.resultDropdownTrigger()?.close();
}
};
Comment thread
NikGurev marked this conversation as resolved.

Expand Down
21 changes: 21 additions & 0 deletions packages/components/breadcrumbs/e2e.playwright-spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,27 @@ test.describe('KbqBreadcrumbs overflow', () => {
await expect(dropdownItems.nth(0)).toHaveText('Item #1');
await expect(dropdownItems.nth(1)).toHaveText('Item #2');
});

test('should hide dropdown panel when breadcrumb items fit into container', async ({ page }) => {
await page.goto('/E2eBreadcrumbsOverflowMax');

const dropdownPanel = () => page.locator('.kbq-dropdown__panel');

const breadcrumbs = page.getByTestId('e2eBreadcrumbsOverflow');
const breadcrumbsHost = page.getByTestId('e2eBreadcrumbsOverflowMaxHost');

await breadcrumbs.locator('.kbq-breadcrumb__expand').click();

await expect(dropdownPanel()).toBeVisible();

const dropdownItems = dropdownPanel().locator('[kbq-dropdown-item]');

await expect(dropdownItems).toHaveCount(2);

await breadcrumbsHost.evaluate(({ style }) => (style.width = '1000px'));

await expect(dropdownPanel()).not.toBeVisible();
});
});

test.describe('KbqBreadcrumbsModule', () => {
Expand Down
7 changes: 7 additions & 0 deletions packages/components/breadcrumbs/e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,13 @@ export class E2eBreadcrumbsStateAndStyle {
<kbq-breadcrumb-item [text]="breadcrumb" [routerLink]="breadcrumb" />
}
</nav>

<!-- Container used for width overflow tests -->
<nav kbq-breadcrumbs data-testid="e2eBreadcrumbsOverflow" [max]="null">
@for (breadcrumb of items; track breadcrumb) {
<kbq-breadcrumb-item [text]="breadcrumb" [routerLink]="breadcrumb" />
}
</nav>
`,
styles: `
:host {
Expand Down