fix(breadcrumbs): close result dropdown when no hidden items (#DS-4578)#1675
Conversation
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
Visit the preview URL for this PR (updated for commit 923b286): https://koobiq-next--prs-1675-a71kjirm.web.app (expires Tue, 07 Jul 2026 07:38:30 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
There was a problem hiding this comment.
Pull request overview
This PR updates the KbqBreadcrumbs overflow behavior so that when all breadcrumb items become visible again (e.g., after a resize), the overflow “result” dropdown panel is closed instead of staying open.
Changes:
- Close the breadcrumbs overflow dropdown trigger when there are no hidden items.
- Extend breadcrumbs E2E fixture to include a
[max]="null"container for width-overflow scenarios. - Add a Playwright test that resizes the host and asserts the dropdown panel disappears.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/components/breadcrumbs/breadcrumbs.ts | Programmatically closes the overflow dropdown when all items are visible. |
| packages/components/breadcrumbs/e2e.ts | Adds an additional breadcrumbs container for width overflow testing. |
| packages/components/breadcrumbs/e2e.playwright-spec.ts | Adds a regression test covering dropdown auto-close when items fit. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.