Skip to content

fix(breadcrumbs): close result dropdown when no hidden items (#DS-4578)#1675

Merged
NikGurev merged 2 commits into
mainfrom
bugfix/DS-4578
Jul 2, 2026
Merged

fix(breadcrumbs): close result dropdown when no hidden items (#DS-4578)#1675
NikGurev merged 2 commits into
mainfrom
bugfix/DS-4578

Conversation

@NikGurev

@NikGurev NikGurev commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@NikGurev NikGurev requested review from artembelik and lskramarov July 1, 2026 13:53
@NikGurev NikGurev self-assigned this Jul 1, 2026
@NikGurev NikGurev added bug Something isn't working 20.x labels Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

🚨 E2E tests failed

Review the report for details.


💡 Comment /approve-snapshots to approve snapshot changes.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 923b286):

https://koobiq-next--prs-1675-a71kjirm.web.app

(expires Tue, 07 Jul 2026 07:38:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the KbqBreadcrumbs overflow behavior so that when all breadcrumb items become visible again (e.g., after a resize), the overflow “result” dropdown panel is closed instead of staying open.

Changes:

  • Close the breadcrumbs overflow dropdown trigger when there are no hidden items.
  • Extend breadcrumbs E2E fixture to include a [max]="null" container for width-overflow scenarios.
  • Add a Playwright test that resizes the host and asserts the dropdown panel disappears.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/components/breadcrumbs/breadcrumbs.ts Programmatically closes the overflow dropdown when all items are visible.
packages/components/breadcrumbs/e2e.ts Adds an additional breadcrumbs container for width overflow testing.
packages/components/breadcrumbs/e2e.playwright-spec.ts Adds a regression test covering dropdown auto-close when items fit.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/components/breadcrumbs/breadcrumbs.ts
Comment thread packages/components/breadcrumbs/e2e.playwright-spec.ts Outdated
@NikGurev NikGurev merged commit 5778159 into main Jul 2, 2026
8 checks passed
@NikGurev NikGurev deleted the bugfix/DS-4578 branch July 2, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

20.x bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants