Skip to content

fix(radio): apply labelPosition properly (#DS-4571) #1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NikGurev merged 4 commits into from
Jul 2, 2026
Merged

fix(radio): apply labelPosition properly (#DS-4571) #1672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9cb75a7
fix(radio): apply labelPosition properly (#DS-4571)
NikGurev Jul 1, 2026
73a0033
test: updated e2e snapshots
NikGurev Jul 1, 2026
cd759cc
chore: after review
NikGurev Jul 2, 2026
e6c34d9
chore: fix padding
NikGurev Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified packages/components/radio/__screenshots__/01-dark.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified packages/components/radio/__screenshots__/01-light.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
15 changes: 15 additions & 0 deletions packages/components/radio/e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,16 @@ export class E2eRadioStateAndStyle {
{ size: 'big', labelPosition: 'after', hovered: true },
{ size: 'normal', labelPosition: 'after', color: ThemePalette.Error, hovered: true }
],
[
{ size: 'normal', labelPosition: 'before' },
{ size: 'big', labelPosition: 'before' },
{ size: 'normal', labelPosition: 'before', color: ThemePalette.Error }
],
[
{ size: 'normal', labelPosition: 'before', hovered: true },
{ size: 'big', labelPosition: 'before', hovered: true },
{ size: 'normal', labelPosition: 'before', color: ThemePalette.Error, hovered: true }
],
[
{ size: 'normal', hint: true, labelPosition: 'after' },
{ size: 'big', hint: true, labelPosition: 'after' },
Expand All @@ -92,6 +102,11 @@ export class E2eRadioStateAndStyle {
{ size: 'normal', hint: true, labelPosition: 'after', disabled: true },
{ size: 'big', hint: true, labelPosition: 'after', disabled: true },
{ size: 'normal', hint: true, labelPosition: 'after', color: ThemePalette.Error, disabled: true }
],
[
{ size: 'normal', hint: true, labelPosition: 'before', disabled: true },
{ size: 'big', hint: true, labelPosition: 'before', disabled: true },
{ size: 'normal', hint: true, labelPosition: 'before', color: ThemePalette.Error, disabled: true }
]
];
protected readonly kbqComponentColors = KbqComponentColors;
Expand Down
6 changes: 1 addition & 5 deletions packages/components/radio/radio.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,11 +411,7 @@ export class KbqRadioButton extends KbqColorDirective implements OnInit, AfterVi
/** Whether this radio is required. */
private _required: boolean;

/**
* Whether the label should appear after or before the radio button. Defaults to 'after'
Comment thread
NikGurev marked this conversation as resolved.
* @TODO: doesn't affect anything. Should be removed or implemented (#DS-4571)
* @docs-private
*/
/** Whether the label should appear after or before the radio button. Defaults to 'after' */
// TODO: Skipped for migration because:
// Accessor inputs cannot be migrated as they are too complex.
@Input()
Expand Down
22 changes: 18 additions & 4 deletions packages/components/radio/radio.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,18 @@
margin-top: var(--kbq-radio-size-normal-vertical-content-padding);
}

[dir='rtl'] & {
padding-right: var(--kbq-radio-size-normal-horizontal-content-padding);
&.kbq-radio-label-before {
padding-left: 0;
padding-right: kbq-sum-series-css-variables(
[radio-size-normal-outer-size,
radio-size-normal-horizontal-content-padding,
calc(var(--kbq-radio-size-normal-outer-circle-border-width) * 2)]
);

.kbq-radio-button__outer-circle {
left: unset;
right: 0;
}
}
}

Expand Down Expand Up @@ -128,8 +137,13 @@
margin-top: var(--kbq-radio-size-big-vertical-content-padding);
}

[dir='rtl'] & {
padding-right: var(--kbq-radio-size-big-horizontal-content-padding);
&.kbq-radio-label-before {
Comment thread
NikGurev marked this conversation as resolved.
padding-left: 0;
padding-right: kbq-sum-series-css-variables(
[radio-size-big-outer-size,
radio-size-big-horizontal-content-padding,
calc(var(--kbq-radio-size-big-outer-circle-border-width) * 2)]
);
}
}
}
Expand Down