fix(radio): apply labelPosition properly (#DS-4571)#1672
Conversation
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
Visit the preview URL for this PR (updated for commit e6c34d9): https://koobiq-next--prs-1672-zxyj018e.web.app (expires Tue, 07 Jul 2026 07:15:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
There was a problem hiding this comment.
Pull request overview
This PR updates the radio component to visually apply labelPosition (specifically the before case) similarly to checkbox, and removes previously existing RTL-specific styling that was reported to be breaking layouts.
Changes:
- Add
.kbq-radio-label-beforestyling to mirror radio label/content layout whenlabelPosition === 'before'. - Remove the outdated inline docs/TODO claiming
labelPosition“doesn't affect anything”. - Extend the radio E2E matrix to include
labelPosition: 'before'states (normal/big, hovered, hint, disabled).
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/components/radio/radio.scss | Adds padding/positioning rules for .kbq-radio-label-before (normal and big sizes). |
| packages/components/radio/radio.component.ts | Removes outdated comment block for labelPosition on KbqRadioButton. |
| packages/components/radio/e2e.ts | Adds new E2E state rows covering labelPosition: 'before'. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🚨 E2E tests failedReview the report for details. 💡 Comment |
Удалил стили для rtl - они только все ломают
Добавил применение labelPosition по аналогии с checkbox, в макетах такого нет