Skip to content

fix(radio): apply labelPosition properly (#DS-4571)#1672

Merged
NikGurev merged 4 commits into
mainfrom
bugfix/DS-4571
Jul 2, 2026
Merged

fix(radio): apply labelPosition properly (#DS-4571)#1672
NikGurev merged 4 commits into
mainfrom
bugfix/DS-4571

Conversation

@NikGurev

@NikGurev NikGurev commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Удалил стили для rtl - они только все ломают

Добавил применение labelPosition по аналогии с checkbox, в макетах такого нет

@NikGurev NikGurev self-assigned this Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

🚨 E2E tests failed

Review the report for details.


💡 Comment /approve-snapshots to approve snapshot changes.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit e6c34d9):

https://koobiq-next--prs-1672-zxyj018e.web.app

(expires Tue, 07 Jul 2026 07:15:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@NikGurev

NikGurev commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

/approve-snapshots

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

🔄 Updating snapshots.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

✅ Snapshots updated!

Comment thread packages/components/radio/radio.scss

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the radio component to visually apply labelPosition (specifically the before case) similarly to checkbox, and removes previously existing RTL-specific styling that was reported to be breaking layouts.

Changes:

  • Add .kbq-radio-label-before styling to mirror radio label/content layout when labelPosition === 'before'.
  • Remove the outdated inline docs/TODO claiming labelPosition “doesn't affect anything”.
  • Extend the radio E2E matrix to include labelPosition: 'before' states (normal/big, hovered, hint, disabled).

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.

File Description
packages/components/radio/radio.scss Adds padding/positioning rules for .kbq-radio-label-before (normal and big sizes).
packages/components/radio/radio.component.ts Removes outdated comment block for labelPosition on KbqRadioButton.
packages/components/radio/e2e.ts Adds new E2E state rows covering labelPosition: 'before'.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/components/radio/e2e.ts
Comment thread packages/components/radio/radio.component.ts
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

🚨 E2E tests failed

Review the report for details.


💡 Comment /approve-snapshots to approve snapshot changes.

@NikGurev NikGurev merged commit b41a1f8 into main Jul 2, 2026
8 checks passed
@NikGurev NikGurev deleted the bugfix/DS-4571 branch July 2, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants