This repository was archived by the owner on Oct 16, 2026. It is now read-only.
Repository navigation
fix(dev): keep error overlay CSS in adoptedStyleSheets - #68
Merged
Merged
Conversation
Page-text readers were picking up overlay <style> text inside the shadow root. Move rules into a CSSStyleSheet so only the dialog copy remains in the text tree. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
kody-bot
marked this pull request as ready for review
October 15, 2026 08:48
Owner
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit b4b3005. Configure here.
2 of 4 tasks
|
🎉 This PR is included in version 1.26.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<style>text node intoCSSStyleSheet/adoptedStyleSheets.Context
Follow-up after the polish stack (#60). Item 5 from the 1.24.0 retest notes (shadow host already existed; CSS was still text in the shadow tree).
Test plan
adoptedStyleSheetsand has no<style>tagsNote
Low Risk
Dev-only overlay presentation change with a source-string regression test; no auth, data, or production runtime impact.
Reviewed by Cursor Bugbot for commit b4b3005. Bugbot is set up for automated code reviews on this repo. Configure here.