This repository was archived by the owner on Oct 16, 2026. It is now read-only.
Repository navigation
fix(dev): absorb late watcher echoes after a failed prebuild - #69
Merged
Merged
Conversation
Slow CI (lts/*) saw one extra rebuild_start ~1s after a failed prebuild when chokidar/poll echoes arrived past the 150ms settle window. Ignore watcher events for 1.5s after failure and lengthen the regression wait. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Owner
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Returning false from onChange leaves the poll fingerprint unadvanced so a real save in the absorb window is seen again after it ends. Soft settle absorb is unchanged (fingerprint still advances). Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Owner
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 016704d. Configure here.
|
🎉 This PR is included in version 1.26.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kody.dev.prebuild, ignore watcher events for 1.5s so late chokidar/poll echoes cannot restart the rebuild loop.Why
Main validate for #68 failed on
lts/*:failed prebuild output must not retrigger the rebuild loopsaw4 !== 3rebuild_start events. That blocked release of #67/#68.Test plan
npm run validateNote
Medium Risk
Changes dev file-watching and rebuild scheduling around failed prebuilds; wrong timing could miss edits or still loop, but scope is limited to
kody dev.Reviewed by Cursor Bugbot for commit 016704d. Bugbot is set up for automated code reviews on this repo. Configure here.