refactor: remap deprecated Contentful theme values to approved themes - #7199
Merged
Conversation
Points the legacy kivaClassic*, kivaDarkMint, imageCard, and ecoStoneDark values at their closest approved design system theme so Contentful content keeps rendering once kv-tokens stops exporting the deprecated themes. The values stay accepted, so no content has to move yet. Adds the missing kivaClassicDarkStone mapping, which ui silently fell back to the default theme for while CPS rendered it dark stone, and fixes the kivaCLassicLight typo that left that key unreachable.
eddieferrer
marked this pull request as ready for review
August 27, 2026 20:55
mcstover
approved these changes
Aug 27, 2026
dyersituations
approved these changes
Aug 27, 2026
This was referenced Aug 28, 2026
kiva-robot
added a commit
that referenced
this pull request
Sep 1, 2026
## [3.91.0-rc.1](v3.90.0...v3.91.0-rc.1) (2026-09-01) ### 🎉 New Features * **live-loan:** render compact bundle card as transparent PNG ([#7204](#7204)) ([131e350](131e350)) ### 🐛 Bugfixes * avoid firing close event on set 2027 goal cta ([2f6a85d](2f6a85d)) * **header:** sync ESI CSS variables for the new header states ([c1da5ba](c1da5ba)) * mykiva initial loading performance improvements ([#7203](#7203)) ([5e836e2](5e836e2)) * opt the header into the ESI avatar ([5f9b4c4](5f9b4c4)) * release withdraw page migration ([#7210](#7210)) ([68a8429](68a8429)) * update kv-components with latest esi support for user avatar ([a54da72](a54da72)) ### 🪚 Refactors * remap deprecated Contentful theme values to approved themes ([#7199](#7199)) ([a9e6de8](a9e6de8)) * remove legacy contentful theme mappings ([#7208](#7208)) ([4fd6d12](4fd6d12)) ### 🧹 Chores * update kv-components with latest KvWwwHeaderBasic fixes ([28d6e96](28d6e96)) * upgrade kv-tokens to 5 and kv-components to 9 ([#7205](#7205)) ([c708e64](c708e64))
Collaborator
|
🎉 This PR is included in version 3.91.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
kiva-robot
added a commit
that referenced
this pull request
Sep 1, 2026
## [3.91.0](v3.90.0...v3.91.0) (2026-09-01) ### 🎉 New Features * **live-loan:** render compact bundle card as transparent PNG ([#7204](#7204)) ([131e350](131e350)) ### 🐛 Bugfixes * avoid firing close event on set 2027 goal cta ([2f6a85d](2f6a85d)) * **header:** sync ESI CSS variables for the new header states ([c1da5ba](c1da5ba)) * mykiva initial loading performance improvements ([#7203](#7203)) ([5e836e2](5e836e2)) * opt the header into the ESI avatar ([5f9b4c4](5f9b4c4)) * release withdraw page migration ([#7210](#7210)) ([68a8429](68a8429)) * update kv-components with latest esi support for user avatar ([a54da72](a54da72)) ### 🪚 Refactors * remap deprecated Contentful theme values to approved themes ([#7199](#7199)) ([a9e6de8](a9e6de8)) * remove legacy contentful theme mappings ([#7208](#7208)) ([4fd6d12](4fd6d12)) ### 🧹 Chores * **release:** 3.91.0-rc.1 [skip ci] ([8170347](8170347)), closes [#7204](#7204) [#7203](#7203) [#7210](#7210) [#7199](#7199) [#7208](#7208) [#7205](#7205) * update kv-components with latest KvWwwHeaderBasic fixes ([28d6e96](28d6e96)) * upgrade kv-tokens to 5 and kv-components to 9 ([#7205](#7205)) ([c708e64](c708e64))
Collaborator
|
🎉 This PR is included in version 3.91.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://kiva.atlassian.net/browse/CIT-4445
Summary
kivaClassicMint,kivaClassicGreen,kivaClassicDark,kivaClassicDarkStone,kivaDarkMint,imageCard, andecoStoneDarkContentful values at their closest approved theme inContentful/StoryCard.vueandContentful/SectionWithBackgroundClassic.vue.kivaClassicMintgoes togreenLightTheme; the dark variants all go togreenDarkTheme, the only approved dark theme. The values stay accepted, so no Contentful content has to move for this to ship.darkGreenThemeforgreenDarkThemeinpages/MonthlyGood/HowItWorks.vue. Despite the near-identical names these are different themes —dark-greenvsgreen-dark— so this one does change how that section looks. See below.kivaClassicDarkStonemapping. ui had no entry for it and silently fell back todefaultThemewhile CPS rendered it dark stone, so 7 published cards (thesuccess-story-*set) looked different between the two apps.kivaCLassicLighttypo (capital L) inStoryCard.vue, which made that key unreachable. No behavior change since the fallback already landed ondefaultTheme.Expected visual changes
/monthlygood— How It Works section. The only change in this PR that is not Contentful-driven, and the most visible.darkGreenThemeandgreenDarkThemeare different themes, not two spellings of one:darkGreenTheme(before)greenDarkTheme(after)--bg-primary#2AA967bright Kiva green#223829dark green--text-primary#F5F5F5#EDF4F1--text-action#2B7C5F#78C79FThe section wrapper carries
tw-bg-primary, so its background goes from bright green to dark green. Confirmed against production, which currently serves--bg-primary:42, 169, 103on that band. Text stays near-white and remains legible; links get lighter. This is a deliberate move onto the approved theme, but it is a real design change and the only production-visible change in this PR — worth a look before merge.The Contentful components in this repo are largely not exercised in production. Contentful landing pages are served by cms-page-server, which has its own copies of
StoryCardandSectionWithBackgroundClassic. In this repo the/lp/:dynamicRouteroute that fedContentfulPageis commented out (// Preserved for cms-page-server rollout, will remove after validation), leaving/hp/:dynamicRoute,/cc/:dynamicRoute(corporate campaign) and/categories. Cross-checking the audit: no affected page key starts withhp/, and no affected page haspageType: corporate-campaign. I sampled 14 of the audited paths against production and every one is CPS-rendered, with none containingbackground-color:rgb(var(--bg-primary))— the fallback unique to this repo's section component.So the Contentful mapper changes here are correctness work to keep this code compiling and consistent with CPS, not a production visual change. The equivalent CPS change is kiva/cms-page-server#3264, and the visible Contentful-driven changes are described there.
Residual unknown:
/categoriespulls a themedFrequentlyAskedQuestionsgroup by key rather than through apageentry, so it would not appear in a page-keyed audit. Worth a spot check.Six previously distinct looks now collapse onto
greenDark, since it is the only approved dark theme. CIT-5073 carries the full audit and the design decision on whether some should land onmarigoldLightorstoneLightinstead.Why now
kv-ui-elements PR #885 removes the
mintTheme,darkTheme,darkGreenTheme,darkMintTheme,darkStoneTheme, andstoneDarkThemeexports from kv-tokens. This repo imported five of them, so it needs to be off those names before a kv-tokens version carrying that change is picked up here.Retiring the legacy values in Contentful and dropping these transitional mapper keys is tracked in CIT-5073, which carries the full audit: 238 published entries sit on a deprecated value, 145 of them reachable from a published page, spanning 85 pages.