refactor: remove deprecated themes from kv-components and kv-tokens - #885
Merged
Conversation
eddieferrer
marked this pull request as ready for review
August 28, 2026 01:08
mcstover
approved these changes
Aug 28, 2026
Drops the stoneDark, mint, and dark theme options from KvCardFrame, KvDatePicker, KvTooltip, and KvSecondaryNav, leaving only the five approved design-system themes. KvSecondaryNav's dark was already a literal alias of greenDarkTheme, so greenDark is a drop-in. KvCheckoutReceipt's tooltip moves from mint to ecoGreenLight, matching the equivalent tooltip in the ui repo. Stories, MDX docs, and the Storybook dark-mode decorator drop the deprecated themes as well. BREAKING CHANGE: the theme props no longer accept stoneDark, mint, or dark. KvCardFrame and KvDatePicker drop stoneDark; KvTooltip drops ecoStoneDark, mint, and dark; KvSecondaryNav drops dark. Use greenDark in place of any dark variant and greenLight in place of mint.
Removes the stoneDarkTheme, darkTheme, mintTheme, darkGreenTheme, darkMintTheme, and darkStoneTheme named exports along with their token destructuring, leaving only the five approved design-system themes. BREAKING CHANGE: kv-tokens no longer exports stoneDarkTheme, darkTheme, mintTheme, darkGreenTheme, darkMintTheme, or darkStoneTheme. Importing any of them fails to build. Map dark variants to greenDarkTheme and mint to greenLightTheme.
Removes the mint, dark, dark-green, dark-mint, dark-stone, and stone-dark semantic theme definitions. The build globs the themes directory and derives theme names from it, so no build config changes were needed. BREAKING CHANGE: the deprecated themes no longer appear in the built token output. designTokens.colors.theme loses the mint, dark, dark-green, dark-mint, dark-stone, and stone-dark keys, and the compiled CSS no longer emits their [data-theme="..."] blocks. Consumers selecting those themes via the data-theme attribute lose their styling.
eddieferrer
force-pushed
the
CIT-4445_remove_deprecated_themes
branch
from
August 28, 2026 16:28
df9e11c to
da804f9
Compare
Collaborator
Author
|
re added commits as breaking changes |
mcstover
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://kiva.atlassian.net/browse/CIT-4445
Summary
stoneDark,mint, anddarktheme options fromKvCardFrame,KvDatePicker,KvTooltip, andKvSecondaryNav, leaving only the five approved design-system themes.KvSecondaryNav'sdarkwas already a literal alias ofgreenDarkTheme, sogreenDarkis a drop-in.KvCheckoutReceipt's tooltip fromminttoecoGreenLight, matching the equivalent tooltip in ui. Stories, MDX docs, and the Storybook dark-mode decorator drop the deprecated themes too.stoneDarkTheme,darkTheme,mintTheme,darkGreenTheme,darkMintTheme, anddarkStoneThemeexports from kv-tokens, then deletes the six underlying semantic theme token files so they no longer appear in the built js, css, or scss output.Downstream cleanup is complete — this is unblocked
The kv-tokens export removal is a breaking change for any consumer importing those names. All consumers are now off them, so this is safe to merge and release:
5bd3db865)a9e6de8ff)developmentandmaster;storyCard.themevalidation list trimmedContentful detail is on CIT-5073: 146 entries republished in development and 136 in master, zero deprecated theme values remaining in either environment, in any state. The retired values (
kivaClassicMint,kivaClassicGreen,kivaClassicDark,kivaClassicDarkStone,ecoStoneDark) are no longer selectable by authors.imageCardwas deliberately retained — it is a layout switch thatStoryCard.vuekeys CSS off, not a colour theme.Both consumer repos still carry transitional mapper keys for the legacy Contentful values. Those are now dead code and will be removed in a follow-up, tracked on CIT-5073 — they do not block this PR.
Verification
dist/js/tokens.jsexposes exactlyDEFAULT,green-dark,green-light,marigold-light,stone-light, anddist/css/tokens.cssemits only the matching[data-theme]blockstokens/**/*.jsonand thekiva/css-themesformat derives theme names from whatever it findsOne unrelated pre-existing failure worth noting:
npm run build:make-kitfails in a clean checkout withENOENT … @kiva/kv-tokens/docs/skills. That directory is not tracked in the repo, so the failure predates these commits, and the script is not part ofbuildorprepare— publishing is unaffected.Note on KvTooltip
KvTooltip's theme prop is replaced wholesale by CIT-4447 (two fixed light/dark variants, noKvThemeProvider). This change just gets it down to approved themes in the meantime.