Skip to content

fix: allow kv-tokens 5.x as a kv-components peer - #888

Merged
eddieferrer merged 1 commit into
mainfrom
CIT-4445_widen_kv_tokens_peer_range
Aug 31, 2026
Merged

fix: allow kv-tokens 5.x as a kv-components peer#888
eddieferrer merged 1 commit into
mainfrom
CIT-4445_widen_kv_tokens_peer_range

Conversation

@eddieferrer

Copy link
Copy Markdown
Collaborator

Ticket: https://kiva.atlassian.net/browse/CIT-4445

Summary

  • Widens kv-components' peer range for @kiva/kv-tokens from 4.x to 4.x || 5.x.

Why

The kv-tokens 5.0.0 release (#885) removed the deprecated theme exports, but left this peer range at 4.x. Consumers cannot therefore install the pair:

npm error ERESOLVE unable to resolve dependency tree
npm error Found: @kiva/kv-tokens@5.0.0
npm error Could not resolve dependency:
npm error peer @kiva/kv-tokens@"4.x" from @kiva/kv-components@9.0.0

Reproduced with npm install @kiva/kv-tokens@5.0.0 @kiva/kv-components@9.0.0 --dry-run in the ui repo. This blocks ui, cms-page-server and any other consumer from taking the new majors.

The range widens rather than moving to 5.x only. kv-components@9 imports just the five approved themes — defaultTheme, greenLightTheme, greenDarkTheme, marigoldLightTheme, stoneLightTheme — all of which exist in both 4.x and 5.x, so both pairings genuinely work. Narrowing to 5.x would also be a breaking change to kv-components and force another major.

Note the workspace dev dependency was already on ^5.0.0; only the published peer contract was stale, which is why CI did not catch it.

Verification

  • npm run lint clean in kv-components
  • Change is a single line in peerDependencies; no source or build changes

Expected release: kv-components 9.0.1 (patch, fix:).

The kv-tokens major that removed the deprecated theme exports left this
peer range at 4.x, so installing kv-components 9 alongside kv-tokens 5
fails with ERESOLVE. Component code imports only the five approved
themes, which exist in both majors, so the range widens rather than
moving to 5.x only.
@eddieferrer
eddieferrer requested a review from a team August 31, 2026 12:00
@eddieferrer
eddieferrer merged commit 13937ad into main Aug 31, 2026
3 of 5 checks passed
@eddieferrer
eddieferrer deleted the CIT-4445_widen_kv_tokens_peer_range branch August 31, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants