fix: allow kv-tokens 5.x as a kv-components peer - #888
Merged
Conversation
The kv-tokens major that removed the deprecated theme exports left this peer range at 4.x, so installing kv-components 9 alongside kv-tokens 5 fails with ERESOLVE. Component code imports only the five approved themes, which exist in both majors, so the range widens rather than moving to 5.x only.
mcstover
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://kiva.atlassian.net/browse/CIT-4445
Summary
kv-components' peer range for@kiva/kv-tokensfrom4.xto4.x || 5.x.Why
The kv-tokens 5.0.0 release (#885) removed the deprecated theme exports, but left this peer range at
4.x. Consumers cannot therefore install the pair:Reproduced with
npm install @kiva/kv-tokens@5.0.0 @kiva/kv-components@9.0.0 --dry-runin the ui repo. This blocks ui, cms-page-server and any other consumer from taking the new majors.The range widens rather than moving to
5.xonly.kv-components@9imports just the five approved themes —defaultTheme,greenLightTheme,greenDarkTheme,marigoldLightTheme,stoneLightTheme— all of which exist in both 4.x and 5.x, so both pairings genuinely work. Narrowing to5.xwould also be a breaking change to kv-components and force another major.Note the workspace dev dependency was already on
^5.0.0; only the published peer contract was stale, which is why CI did not catch it.Verification
npm run lintclean in kv-componentspeerDependencies; no source or build changesExpected release: kv-components 9.0.1 (patch,
fix:).