Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 827bf6e105
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please review the current head |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Change
Adds explicit read-only stdio attachment to an already-running numeric loopback HTTP daemon:
codex-memoryd --url http://127.0.0.1:8989 mcp stdio --daemon --profile personal --workspace defaultDaemon attachment exits before local configuration or SQLite initialization. Status, recall, and search use the existing typed HTTP API and MCP dispatcher. The profile and workspace are fixed; status omits global inventories and local paths. The client disables redirects and ambient proxies, bounds request/response bodies and total request time, and sanitizes transport/API/auth/capability errors. It neither starts nor migrates a daemon or falls back to a local store.
Scope
Bounded first slice of #247. External tunnel profile setup, tunnel-client packaging/UX, release-shaped hosted ChatGPT connectivity proof, and later #233 write continuity remain incomplete. No tunnel-client code is vendored.
Validation
The prior real-subprocess regression reproduced ambient-runtime selection/logging before the fix. Synthetic tests cover an impossible local storage home, mixed scopes, secret-blocked facts, outage/reconnection, adapter restart, redirects, timeouts, malformed/oversized payloads, auth/capability errors, and direct/local stdio compatibility.
Latest head:
9ed1ecd777072029babac4c046f2f64db886bcb6.NO_PROXY.cargo test --test mcp_daemon --test mcp_stdio— 25 passed (10 daemon, 15 stdio, including official rmcp discovery).827bf6e105and reported two findings: stale attachment guidance and a proxy-dependent test probe. Both are fixed in9ed1ecd, and both corresponding review threads are resolved. The owner-approved latest-head Codex connector review completed at 13:09 UTC on9ed1ecd777072029babac4c046f2f64db886bcb6and found no major issues. This single additional review was explicitly authorized because the repair push did not receive an automatic review. With exact-head CI passing and both prior threads resolved, MERGE_READY YES. No merge or deployment is authorized.The earlier pre-#266 checkpoint had 578 tests and is superseded by the post-integration results above. No real-memory corpus, operator/Dakota dogfood, production deployment, tagging, release, or PR merge was performed.