Skip to content

Add $wgSmjExplorerEnabled, off by default - #84

Merged
jmnote merged 1 commit into
mainfrom
explorer-setting
Oct 8, 2026
Merged

jmnote merged 1 commit into
mainfrom
explorer-setting

Conversation

@jmnote

@jmnote jmnote commented Oct 8, 2026

Copy link
Copy Markdown
Owner

Summary

MathJax 4 enriches every formula for its accessibility explorer. As a side effect, a left click on a formula selects and highlights a symbol (or the whole expression), which surprises readers who just want to read or select text.

  • New setting $wgSmjExplorerEnabled (default false), exported to the client like the other wgSmj* settings, mapped to MathJax.options.menuOptions.settings.enrich.
  • Off: no semantic enrichment, so no click selection/highlight, no speech or Braille output. Readers can still turn it on per browser from the MathJax menu (right-click → Accessibility).
  • On: MathJax's default behavior.
  • Docs: README table, docs/configuration.md (table and a section).

options.enableExplorer: false and menuOptions.settings.explorer: false do not stop the click selection in MathJax 4.1.3; only turning enrichment off does.

Tests

  • make checks passes (JsDefaultsTest covers the new client default against extension.json).
  • Browser, MediaWiki 1.43, a page with 84 formulas: default → wgSmjExplorerEnabled: false, no has-speech, a click highlights nothing; with the setting on → speech attached to all 84. All formulas render in both cases.

MathJax 4 enriches formulas for its accessibility explorer, so a click
selects and highlights a symbol. Turn semantic enrichment off by default
(menuOptions.settings.enrich); readers can enable it from the MathJax
menu, and sites can enable it for everyone with $wgSmjExplorerEnabled.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T16:57:52.753697Z 9bcacb6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jmnote
jmnote merged commit af51d7c into main Oct 8, 2026
2 checks passed
@jmnote
jmnote deleted the explorer-setting branch October 8, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant