Repository navigation
Apply $wgSmjEnableMenu to MathJax.options.enableMenu - #85
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The setting was exported to the page but never read by the client, so $wgSmjEnableMenu = false had no effect.
jmnote
force-pushed
the
enable-menu-fix
branch
from
October 8, 2026 17:10
48e67ef to
180eabf
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #84 (same lines); after #84 is merged the base becomes main.
$wgSmjEnableMenuis documented asMathJax.options.enableMenuand exported to the page, but the client never read it, so setting it tofalsehad no effect. The client now passes it tooptions.enableMenu(defaulttrue, checked againstextension.jsonbyJsDefaultsTest).Browser, MediaWiki 1.43: right-click on a formula opens the MathJax menu by default; with
wgSmjEnableMenu: falseno menu opens. All 84 formulas render in both cases.make checkspasses.