Skip to content

ServeError should propertly set headers #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
minigolf2000 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ServeError should propertly set headers #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions apiutils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,21 +68,25 @@ func NewErrorResponse(status int, message string) ErrorResponse {
}

func ServeJSON(w http.ResponseWriter, v interface{}) {
serve(w, v, http.StatusOK)
}

func ServeError(w http.ResponseWriter, errRes ErrorResponse) {
serve(w, errRes, errRes.Status)
}

func serve(w http.ResponseWriter, v interface{}, status int) {
content, err := json.MarshalIndent(v, "", " ")
if err != nil {
http.Error(w, err.Error(), http.StatusInternalServerError)
return
}
w.Header().Set("Content-Length", strconv.Itoa(len(content)))
w.Header().Set("Content-Type", "application/json")
w.WriteHeader(status)
w.Write(content)
}

func ServeError(w http.ResponseWriter, errRes ErrorResponse) {
w.WriteHeader(errRes.Status)
ServeJSON(w, errRes)
}

const (
StatusUnprocessableEntity = 422
)
Expand Down