ServeError should propertly set headers#4
Open
minigolf2000 wants to merge 1 commit into
Open
Conversation
jixwanwang
approved these changes
Aug 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful responses are correctly being handled. But currently there's a bug where
ServeErrorreturns the response body without actually setting headers. As a result,Content-Lengthis not set, andContent-Typeends up defaulted totext/plain charset=utf-8.The reason is because https://golang.org/pkg/net/http/#ResponseWriter
The correct order of operations, for both success and failure, is:
w.Header().set()w.WriteHeader()w.Write()I noticed Vinyl has this bug too lol we should fix that at some point.