Skip to content

ci(jenkins): skip Windows executable signing when RUN_CHOCOLATEY is disabled #3520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BlasttS merged 1 commit into from
May 28, 2026
Merged

ci(jenkins): skip Windows executable signing when RUN_CHOCOLATEY is disabled #3520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,9 @@ def runRelease(architectures) {
}

// We sign the binary also for the standalone Windows executable, and not just for Windows executable packaged inside Chocolaty.
downloadToolsCert()
if (params.RUN_CHOCOLATEY) {
downloadToolsCert()
}
if (params.RUN_UPLOAD_CLI) {
stage('Upload CLI') {
print "Uploading version $version to Repo21"
Expand Down Expand Up @@ -445,7 +447,7 @@ def build(goos, goarch, pkg, fileName) {
env.GOOS=""
env.GOARCH=""

if (goos == 'windows') {
if (goos == 'windows' && params.RUN_CHOCOLATEY) {
dir("${jfrogCliRepoDir}build/sign") {
// Move the jfrog executable into the 'sign' directory, so that it is signed there.
sh "mv ${jfrogCliRepoDir}${fileName} ${fileName}.unsigned"
Expand Down
Loading