Repository navigation
ci(jenkins): skip Windows executable signing when RUN_CHOCOLATEY is disabled - #3520
Merged
Merged
Conversation
…isabled Gate the Windows signing block in build() and the downloadToolsCert() call on params.RUN_CHOCOLATEY so dev/test runs without the Chocolatey stage don't require the signing cert and Docker-based signing step.
BlasttS
approved these changes
May 28, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build()onparams.RUN_CHOCOLATEYso the Docker-based signing step is skipped on runs that don't publish to Chocolatey.downloadToolsCert()in that case, since the cert is only consumed by the (now-skipped) Windows signing step.When
RUN_CHOCOLATEY=true(the default), behavior is unchanged. When it is disabled, the standalone Windows.exeuploaded byuploadCliwill be unsigned — intended for dev/test runs without access to the signing infrastructure.Test plan
RUN_CHOCOLATEY=falseand confirm no signing/cert download stages execute and the Windows binary uploads succeed.RUN_CHOCOLATEY=trueand confirm signing still happens for both the standalone Windows exe and the Chocolatey package.